Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AF6C433F5 for ; Wed, 15 Dec 2021 09:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241121AbhLOJWY (ORCPT ); Wed, 15 Dec 2021 04:22:24 -0500 Received: from smtp23.cstnet.cn ([159.226.251.23]:42592 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236374AbhLOJWX (ORCPT ); Wed, 15 Dec 2021 04:22:23 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-03 (Coremail) with SMTP id rQCowABHTFi1s7lhhdkLAw--.32516S2; Wed, 15 Dec 2021 17:21:58 +0800 (CST) From: Jiasheng Jiang To: david.kershner@unisys.com, gregkh@linuxfoundation.org, chensong_2000@189.cn Cc: sparmaintainer@unisys.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] staging: unisys: potential dereference of null pointer Date: Wed, 15 Dec 2021 17:21:55 +0800 Message-Id: <20211215092155.141029-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: rQCowABHTFi1s7lhhdkLAw--.32516S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtw4ftrW5KFW5JFykKr4Durg_yoWfKFX_Cr Z29w4fJry0y34fu3WUGry7Zr92kFZFqw4F93WfK3y3KFWDX3ZxArW8ur1Yqry3JF17tryU CFWqvryrtr17AjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_GFWl 42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAK I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r 4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUeLvtDUUUU X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The return value of kmalloc() needs to be checked. To avoid devdata->cmdrsp to be null in case of the failure of alloc. Fixes: d2c3506be646 ("staging: unisys: Add s-Par visorhba") Signed-off-by: Jiasheng Jiang --- drivers/staging/unisys/visorhba/visorhba_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c index 4455d26f7c96..a23c300447e9 100644 --- a/drivers/staging/unisys/visorhba/visorhba_main.c +++ b/drivers/staging/unisys/visorhba/visorhba_main.c @@ -1056,6 +1056,9 @@ static int visorhba_probe(struct visor_device *dev) idr_init(&devdata->idr); devdata->cmdrsp = kmalloc(sizeof(*devdata->cmdrsp), GFP_ATOMIC); + if (!devdata->cmdrsp) + goto err_debugfs_info; + visorbus_enable_channel_interrupts(dev); scsi_scan_host(scsihost); -- 2.25.1