Message-ID: <612eadcf-7b12-6609-9397-5c3cb7064f6b@redhat.com>
Date:   Wed, 15 Dec 2021 10:25:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset
 parameter
Content-Language: en-US
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <20211215010008.2545520-1-javierm@redhat.com>
 <58d00cac-dbf1-9704-3c0b-16fd837a5b6b@suse.de>
 <2e76bd93-a65e-094c-15a4-77375906a1b0@suse.de>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <2e76bd93-a65e-094c-15a4-77375906a1b0@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Thomas,

On 12/15/21 10:12, Thomas Zimmermann wrote:

[snip]

>>
>> In each of the USB-based DRM drivers, replace module_usb_driver with 
>> drm_module_usb_driver.
>>
>> And then there's PCI [3] and platform drivers, [4] which can be handled 
>> similarly. Many PCI drivers open-code the module init and device 
>> registering with the driver-specific enable parameter. Maybe adding a 
>> driver-specific register function would make sense.
> 
> Just want to point out that the next time we add a new driver, it will 
> call drm_firmware_drivers_only() automatically if it uses such a macro.
> 

Yes, and it could also be used as an extension point in case we need more
logic like the drm_firmware_drivers_only() check for all drivers in the
future. So your suggestion is certainly the way to go.

I'll post a v2 when I get some time to work on this again.

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat