MIME-Version: 1.0
References: <1638867233-8383-1-git-send-email-vincent.sunplus@gmail.com>
 <1638867233-8383-2-git-send-email-vincent.sunplus@gmail.com>
 <1b336b98-7546-93e3-f1ed-92d041c2df35@linaro.org> <CAPvp3RgqQ_M9rXfkWFTC5zOgk7OUGO1=o8wDjxiB+5wMPoS_Rg@mail.gmail.com>
 <36d17f8b-2480-6c1d-fe84-d4bd04e4170f@linaro.org>
In-Reply-To: <36d17f8b-2480-6c1d-fe84-d4bd04e4170f@linaro.org>
From:   =?UTF-8?B?5pa96YyV6bS7?= <vincent.sunplus@gmail.com>
Date:   Wed, 15 Dec 2021 17:45:07 +0800
Message-ID: <CAPvp3RiA_vGWV7z_MFKOH4iwjC4qLJavTv0Oz==Er5nS8wBUhg@mail.gmail.com>
Subject: Re: [PATCH v2 1/2] nvmem: Add driver for OCOTP in Sunplus SP7021
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        devicetree@vger.kernel.org, wells.lu@sunplus.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

hello

Srinivas Kandagatla <srinivas.kandagatla@linaro.org> =E6=96=BC 2021=E5=B9=
=B412=E6=9C=8814=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=885:08=E5=AF=
=AB=E9=81=93=EF=BC=9A
>
>
>
> On 10/12/2021 08:50, =E6=96=BD=E9=8C=95=E9=B4=BB wrote:
> >
> >      > +
> >      > +static const struct of_device_id sp_ocotp_dt_ids[] =3D {
> >      > +     { .compatible =3D "sunplus,sp7021-ocotp", .data =3D &sp_ot=
p_v0 },
> >      > +     { }
> >      > +};
> >      > +MODULE_DEVICE_TABLE(of, sp_ocotp_dt_ids);
> >      > +
> >      > +static struct platform_driver sp_otp_driver =3D {
> >      > +     .probe     =3D sp_ocotp_probe,
> >      > +     .driver    =3D {
> >      > +             .name           =3D "sunplus,sp7021-ocotp",
> >      > +             .of_match_table =3D sp_ocotp_dt_ids,
> >      > +     }
> >      > +};
> >      > +
> >      > +static int __init sp_otp0_drv_new(void)
> >      > +{
> >      > +     return platform_driver_register(&sp_otp_driver);
> >      > +}
> >      > +subsys_initcall(sp_otp0_drv_new);
> >
> >     Why this needs to be subsys_initcall() why can't it be module_init?
> >
> >   The OTP driver will store the mac address for ethernet driver and usb=
2
> > disconnect voltage
> >   for usb2 one. Therefore the order of the OTP driver should take highe=
r
> > priority over the
> > other ones.
>
> drivers that are looking for mac address or other values from nvmem
> should get an EPROBE_DEFER if nvmem provider is not ready.
>
> does that not work for you?
>
>
> --srini

After modification and verification, I found the algorithm of
EPROBE_DEFER worked.
I will replace subsys_initcall() with module_init() for the driver.
Thanks for your review.