From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Paolo Bonzini <pbonzini@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
CC:     Jing Liu <jing2.liu@linux.intel.com>,
        "Zhong, Yang" <yang.zhong@intel.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Nakajima, Jun" <jun.nakajima@intel.com>
Subject: RE: [patch 4/6] x86/fpu: Add guest support to xfd_enable_feature()
Thread-Topic: [patch 4/6] x86/fpu: Add guest support to xfd_enable_feature()
Thread-Index: AQHX8JVfa24MaOKR6ES6APNYc0mH4qwxeZawgABOEICAADCUgIABC9hQgABN3gCAAAJ6MA==
Date:   Wed, 15 Dec 2021 10:02:44 +0000
Message-ID: <BN9PR11MB5276D9BADF36A750ED9ACD3D8C769@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20211214022825.563892248@linutronix.de>
 <20211214024947.991506193@linutronix.de>
 <BN9PR11MB5276D76F3F0729865FCE02938C759@BN9PR11MB5276.namprd11.prod.outlook.com>
 <f49f9358-a903-3ee1-46f8-1662911390ef@redhat.com> <87a6h3tji8.ffs@tglx>
 <BN9PR11MB52760A4BC211148D875D3F358C769@BN9PR11MB5276.namprd11.prod.outlook.com>
 <87bl1iry7z.ffs@tglx>
In-Reply-To: <87bl1iry7z.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xODa4KhiBHdgJRJg4YCGpgLSHCxPknI8Q0k8fEDjSz1ToJTkUzLnZx+Y4kUt?=
 =?us-ascii?Q?CqZ9404tNQbI0/o249cs06TBJ/Y2k8fFVoH+47RPPIUl4cENQ0qDFVlyxj0N?=
 =?us-ascii?Q?fYe7ewsP50E5PXeaLwkO04xjC+W56hPwzV6YTZ3ajwM4q3ShtvMc34fetogB?=
 =?us-ascii?Q?W0A3uTaEQbAM5RcewgCtjHVtnu3I1bKvozfBhKxnG27Ou+y/9sDnxFFEXH/T?=
 =?us-ascii?Q?A59bHQ02MxJAJ7d9uUYZIKyAWKlawfeYa12AhO+9O8allL412wz5NMEKlXGm?=
 =?us-ascii?Q?jmbj3UasP0LT7seM0UT1TDO2XlY6+UAV5kRyFK6QW9wTAoeUR+qIIvq0DSoa?=
 =?us-ascii?Q?sVxVddKTATOlsXuZOBZUN9QMXau0PxN4/HkXMCva6HFqB2vMuxlzmPz3n8JA?=
 =?us-ascii?Q?Uus53S87o3t52Sfk4xuG6ETIop585Lv0Kqp+Ar3kxsTltiQGbv8byeFuHhJN?=
 =?us-ascii?Q?jfhlPs53SAeikc6frUoEqap4646YWoaMt2dl1nL7MuYRa+XdlyiWNcu1SXmz?=
 =?us-ascii?Q?fyhRo0UfYLrcd1sDtTzpC18DLBb+OVFOeoa8vqdLAgAZIZevKSfZmTFPQ/Ey?=
 =?us-ascii?Q?BpUGYQu6c0ernbra+omFmXfwvQ3+cBduu8itGEFjgk5LRadLz/wRlJEu0Mdg?=
 =?us-ascii?Q?gZ1QU3TnVNqwNbTb9iDGdS4NYHyYdVvdslPYXV6A9xWsHOVeOqCY16jK0jEc?=
 =?us-ascii?Q?Xu8oKw48kHBGQ1PmXE6gCguKwn9SCgPhU1oXpC9vd/DC0ilmw10OmrhWnRPq?=
 =?us-ascii?Q?JSowGUBsX0b89jgtykdLp4EiNuzXZszgBTLrxO9V7Novx1gkgKs22npJzsVE?=
 =?us-ascii?Q?dnKwXRzFyWTkrHK3EL8GGOXySNzIPUr1SKm5STdoN/JYK9KwC+zNIjPKHCPb?=
 =?us-ascii?Q?m28gSFzYUZw9+wRtCxFFMz/GJtczflxS+FH4QqoLYlu1piu0yV2xxnoJ9cQP?=
 =?us-ascii?Q?OSW4PS1DsQYESp5SobTZQS2+MkjxijjERHwEY5g47xcx8UDRs2BPF9FD+NPg?=
 =?us-ascii?Q?k6vh9J+aWKU0yE5+nOZ0IaYXexxsfOpJIO1d3j2/kJGgNWN1IbAniHaPEDNh?=
 =?us-ascii?Q?2j7Hc0Ev7j/8BxN0gegnU79mnvhuJm19hU5VkiezOf0SRQkkaNxDmc5TVsi1?=
 =?us-ascii?Q?opcvvttUD7GErWjx5O/AwqS0szWK3B4Y/9DhVdcnK6LnCvUo29ZhqbXWqf45?=
 =?us-ascii?Q?7SFEtt0bS1isU6Jyjt//NOt1MHUfqHHw9W52977p5OkY3BFc19lCZhPln/sJ?=
 =?us-ascii?Q?B2bX54fwoQzdHmPszikzmyVFE8edVMH5QUieAOP39TBBcyNQeiGQU3aGx5n4?=
 =?us-ascii?Q?ShwBOzhz4ncX2uH1kl0Vv0UFC+L/ZyzYmG6BvW4zYYXpcuCcDIRsavZ7gzYd?=
 =?us-ascii?Q?1QAm1YT/xwO8TyST+FaoVsgCCmYutyJqpg5PaR4nWjy6/TkQhFokGo0b6CMd?=
 =?us-ascii?Q?WgmJLfsBKU+FlDANHOHFPnBSzuChI2YGKcP0JgIDftllt0NpFH8/3Ptelqz+?=
 =?us-ascii?Q?OgLv2Ukn7PbczSWaJwSzgKkz+hIrGD3YT1jBaK4LxQnBqK+78U4zkz/jdCzU?=
 =?us-ascii?Q?2Rlh4Aw4BKyDBzK6ElTYLOPlwRQs31U0O3wDu9X8uPfCZHIKXKe5WF2CzHlT?=
 =?us-ascii?Q?4j5GGnuywggYV/a29SdlvQs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a65729c-a758-47aa-66d5-08d9bfb20a21
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 10:02:44.2809
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +E0JOfVIhCG1bxR/HEU3K9CtIKfV0Y5iL8sOIO/AAypgR67OYmmtFNPPRqo7xWu2oB2MFM5cRpxg8ESTbD1h5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1649
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Wednesday, December 15, 2021 5:53 PM
>=20
> On Wed, Dec 15 2021 at 05:46, Kevin Tian wrote:
> >> From: Thomas Gleixner <tglx@linutronix.de>
> >> +	if (guest_fpu) {
> >> +		newfps->is_guest =3D true;
> >> +		newfps->is_confidential =3D curfps->is_confidential;
> >> +		newfps->in_use =3D curfps->in_use;
> >
> > What is the purpose of this 'in_use' field? Currently it's only
> > touched in three places:
> >
> >   - set when entering guest;
> >   - cleared when exiting to userspace;
> >   - checked when freeing a guest FPU;
> >
> > The last one can be easily checked by comparing to current fps.
>=20
> I added it for paranoia sake because the destruction of the KVM FPU
> state is not necessarily in the context of the vCPU thread. Yes, it
> should not happen...
>=20
> >> +	if (guest_fpu) {
> >> +		curfps =3D xchg(&guest_fpu->fpstate, newfps);
> >
> > This can be a direct value update to guest_fpu->fpstate since
> > curfps has already been acquired in the start.
>=20
> Indeed.
>=20

Thanks for confirmation. We'll include those changes in next version.

Thanks
Kevin