Message-ID: <0aaf9792fad706519da3c0177151dc2316882706.camel@pengutronix.de>
Subject: Re: [PATCH resend v3] reset: renesas: Fix Runtime PM usage
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Biju Das <biju.das.jz@bp.renesas.com>,
        Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Wed, 15 Dec 2021 11:21:15 +0100
In-Reply-To: <OS0PR01MB592202E7612FF6C0F0FCE76086769@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <ec24e13f-0530-b091-7a08-864577b9b3be@gmail.com>
         <OS0PR01MB592202E7612FF6C0F0FCE76086769@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2021-12-15 at 10:18 +0000, Biju Das wrote:
> Hi Heiner,
> 
> Thanks for the patch.
> 
> > Subject: [PATCH resend v3] reset: renesas: Fix Runtime PM usage
> > 
> > If pm_runtime_resume_and_get() fails then it returns w/o the RPM usage
> > counter being incremented. In this case call pm_runtime_put() in
> > remove() will result in a usage counter imbalance. Therefore check the
> > return code of pm_runtime_resume_and_get() and bail out in case of error.
> > 
> > Fixes: bee08559701f ("reset: renesas: Add RZ/G2L usbphy control driver")
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Thank you both, applied to reset/fixes.

regards
Philipp