Date:   Wed, 15 Dec 2021 12:01:39 +0100
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Francesco Dolcini <francesco.dolcini@toradex.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        netdev@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up
Message-ID: <20211215110139.GA64001@francesco-nb.int.toradex.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DB8PR04MB679570A356B655A5D6BFE818E6769@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <YbnDc/snmb1WYVCt@shell.armlinux.org.uk>
 <Ybm3NDeq96TSjh+k@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jXmHLV9zglTTwiJhaz0mNzY8Q5Lhh7GVVMjQzrl3FfliHrCvvxccd4nMcYYA?=
 =?us-ascii?Q?gspClqJfc0A+mendeUo16IvyavgUfcrgwgCLKHii8TPczi9F3jO1vy2I/ArO?=
 =?us-ascii?Q?WTrSAOK0MrY7RYD+aqglouqcArwksM34u1olF4kZ7nwD54R/blm8HSqMRhCe?=
 =?us-ascii?Q?WT0Fmp7bbOJ2fi+2U89U9kWYHrmUZbKOPTny/96xu2MeY5TNz/8d4LsWk/2r?=
 =?us-ascii?Q?3+dUmIOpIBGhtYlx9yZgHNMPDgUqnj7gpw9cpkrkffK0LWgYR+s5mPaKLcWe?=
 =?us-ascii?Q?nTd/j9ZDtiq+LYJDiF+L9r1YvCmxNTI8GAaWk1n1lBMsSEtsr0Tkk4VTZkxD?=
 =?us-ascii?Q?ez9AcFGaH/PHhoVzQTTsyHG7VCyyRepRX1d/qK/vMt2ODuv3gk9R+lYR5LvN?=
 =?us-ascii?Q?svGEIxNR/Ncd6LH8LZc6m2izM2oNCDiAb1UZmPgAA8SLB2Xnf2TfyI9L1uIk?=
 =?us-ascii?Q?TsFxntx650ppAVmJUcqMNzXekgYLHvFSJnVvm7dkSj+OUgHq66JXVR55hPBu?=
 =?us-ascii?Q?4PPwu0ti+6bNIUMtEja2wG+DTTuntsl9W84RdL0rQ0Hc/eoYi8Doq4TvLAB9?=
 =?us-ascii?Q?3mqi34CiAv20kgtKsUMTEoG3dYW0hBVl5JViUPlNBpdegmfyDmxsPlgj9+kC?=
 =?us-ascii?Q?quex695Zl5mEHYI26jStPhF2desezrrlBwY/3cGZwZRykuLa1Y5FYn2dUE1q?=
 =?us-ascii?Q?EXlb0bZlfUajjvILLrcFyuz5pvZ6+a8xUC7OEYWtw+5JN7ojFJvOoh7oW1qU?=
 =?us-ascii?Q?JF1Qjgb9573JIoPl3k9bncx0pOxXO0pZOqcYFhV++Lh7oO8AeYtz1hCXYaUd?=
 =?us-ascii?Q?XutZmcRsIl2EPcxpTructdpPF0AscaXyBK2EFTmfmkRDDaBBTQYf113cSYhf?=
 =?us-ascii?Q?6U6l34sXqroOR9PZ83gWLJFVhE8DwQ7qVnfg11mEJ0Mg6GlGQ35AJRBZDCrX?=
 =?us-ascii?Q?h4qQW3o8KUDt+hpC1qQrEn5egXP77A8v0LVEnkxUsjZJBQ7u9RUjbaFTKa/d?=
 =?us-ascii?Q?aIBZjmClLEGwHe1IY3zZtFNGWoY4OYEiO6SFwYWhTAHrslurClmPqT1N2UW+?=
 =?us-ascii?Q?FNGNI//UlIgXii4CnYDcSVnxJD0PxJUS33sMDLuttMcFipESK4ds/qgkNtFW?=
 =?us-ascii?Q?gNxC+rYq4c+1yz9ILQBib0zo9UYo6wUJe5pQbsdjsl/6k4DrJlEcf3v8AbpB?=
 =?us-ascii?Q?ZbVu82LHRCOwsg2USZQgt+As6c/T9GbPZqJf4dhl89dWjvhc/SL/XEL5cWfX?=
 =?us-ascii?Q?1cx3micTXr+sx8ip3Pte8o4V06BSUAv4AJChlDj+kHoXL8MYiiTLdF+Z0uid?=
 =?us-ascii?Q?Ll2SVDQ1FJo0R6TL2H3r4TQ4zo9xKNsrlK/htSIKpxahgfV37BjB1R++BffJ?=
 =?us-ascii?Q?E6zlhOiyjXTU19oxEPrn7j8jx+CBy/qb8uFFoZf+bDD+fdTfK0eX/wm0RHpK?=
 =?us-ascii?Q?h7IyesOqqJ8mbMC5I9khbtb4vmplOseq43KiWxjfvwt8ehNOXpaWW/OHUCbE?=
 =?us-ascii?Q?B2uikLkp/8gIxnfvLaSaSmLble8subdOYAdyXIyoJlyC6ZZW6ovtEyYVroDu?=
 =?us-ascii?Q?9lCCuyoza+xwdr2etf7VonImqClVgO4IXSB+2KyqtV65aHy2gN8eV21rmeEi?=
 =?us-ascii?Q?DO1NfeznxbbWI06/sELQDk0YAfpez30CxRbmrr8u9G0ao0vm1w2hoLQpMoWW?=
 =?us-ascii?Q?9Hlc2cibs+PHaiOsz9lcDVS/r1k=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17788432-b52b-4c0f-773b-08d9bfba45da
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 11:01:40.7170
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZwxQdcFhwlyUfTF7AgHvCOJWgZivTVEl9nuJFTwN2Y/PW2AS/EX9xXCZLPF5+nRoSnn+9QgmSRSanIJgheZTqYR81Hx3cc89uUWyhBKFWvo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0348
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 15, 2021 at 10:36:52AM +0100, Andrew Lunn wrote:
> On Tue, Dec 14, 2021 at 11:35:48PM +0100, Francesco Dolcini wrote:
> > Hello Andrew,
> > 
> > On Tue, Dec 14, 2021 at 07:54:54PM +0100, Andrew Lunn wrote:
> > > What i don't particularly like about this is that the MAC driver is
> > > doing it. Meaning if this PHY is used with any other MAC, the same
> > > code needs adding there.
> > This is exactly the same case as phy_reset_after_clk_enable() [1][2], to
> > me it does not look that bad.
> > 
> > > So maybe in the phy driver, add a suspend handler, which asserts the
> > > reset. This call here will take it out of reset, so applying the reset
> > > you need?
> > Asserting the reset in the phylib in suspend path is a bad idea, in the
> > general case in which the PHY is powered in suspend the
> > power-consumption is likely to be higher if the device is in reset
> > compared to software power-down using the BMCR register (at least for
> > the PHY datasheet I checked).
> 
> Maybe i don't understand your hardware.
> 
> You have a regulator providing power of the PHY.
> 
> You have a reset, i guess a GPIO, connected to the reset pin of the
> PHY.
> 
> What you could do is:
> 
> PHY driver suspend handler does a phy_device_reset(ndev->phydev, 1)
> to put the PHY into reset.
> 
> MAC driver disables the regulator.
> 
> Power consumption should now be 0, since it does not have any power.
> 
> On resume, the MAC enables the regulator. At this point, the PHY gets
> power, but is still held in reset. It is now consuming power, but not
> doing anything. The MAC calls phy_hw_init(), which calls
> phy_device_reset(ndev->phydev, 0), taking the PHY out of reset.
> 
> Hopefully, this release from reset is enough to make the PHY work.
This is all correct and will solve the issue, however ...

The problem I see is that nor the phylib nor the PHY driver is aware
that the PHY was powered down, if we unconditionally assert the reset in
the suspend callback in the PHY driver/lib this will affect in a bad
case the most common use case in which we keep the PHY powered in
suspend.

We would have to move the regulator in the PHY driver (phy/micrel.c) to
do it properly.

The reason is that the power consumption in reset is higher in reset
compared to the normal PHY software power down.

This will create a power consumption regression for lot of users.

Doing this into the FEC driver would not have this issue, since we know
if we have a regulator (I guess you saw my one line patch for it).


On Wed, Dec 15, 2021 at 10:29:07AM +0000, Russell King (Oracle) wrote:
> Here's another question which no one seems to have considered. If the
> PHY power source can be controlled, why doesn't the firmware describe
> the power supply for the PHY, and why doesn't the PHY driver control
> the PHY power source? Why is that in the SoC network driver?
Legacy/historical reasons ...

In the first RFC patch for this issue this was mentioned by Philippe,
but than the discussion went into another direction.

As I wrote above if we handle both reset/regulator in the PHY driver it
should work, just a little bit tricky because phy/micrel.c handle a
whole family of phys.


On Wed, Dec 15, 2021 at 10:25:14AM +0000, Joakim Zhang wrote:
> As I mentioned before, both mac and phylib have not taken PHY reset
> into consideration during system suspend/resume scenario. As Andrew
> suggested, you could move this into phy driver suspend function, this
> is a corner case. One point I don't understand, why do you reject to
> assert reset signal during system suspended? 
See my answer to Andrew above, in short asserting the reset without
disabling the regulator will create a regression on the power
consumption.

Any agreement on how to move forward?

 1. add phy_reset_after_power_on() and call it from FEC driver (current
 patchset)
 2. assert phy reset in FEC driver suspend (one line patch from me in
 this thread)
 3. move regulator to phy/micrel.c and assert reset in the phy driver resume
 callback
 4. ?

?

Francesco