Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B29C433F5 for ; Wed, 15 Dec 2021 11:34:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237273AbhLOLey (ORCPT ); Wed, 15 Dec 2021 06:34:54 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:46843 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234047AbhLOLew (ORCPT ); Wed, 15 Dec 2021 06:34:52 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E333F5C0346; Wed, 15 Dec 2021 06:34:51 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute3.internal (MEProxy); Wed, 15 Dec 2021 06:34:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm3; bh=m3LAop276JGnuIzrbo3h0hI4rst+ 9X0A+rv7sty1g70=; b=QHUfO1ZT7H+y/sweUvnZTrMZKGCc/fLq1ft4S2MVkOHQ dgIW3qrcxFtsMP52lrFj5anX2btycq2kWEwhupbNDexEdlztHucsnPxaZE2QWh2I OGZYAUByiAsZ9lktB4BYSyPUE25kA4HthSKSgjX3LsiqH6ptjXDP6nGbG+6ZwsPI FaSk31h3rFXzODeE9iW2dfLav0Vtww83olmlKOcOeqMiMS5VU/bFD8k8USIhF14Z PcyZMVK3nglsCWvSiBh7uI9svgvR93pPkOm7HrnzTMiwC2tNLqYRIt1xahQsWiSs LwyuDuWH+I2ILRsRkKg3pdePkmE7ukrG1t1yXtmCVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=m3LAop 276JGnuIzrbo3h0hI4rst+9X0A+rv7sty1g70=; b=T3SH6Rt6Wsvjl84z1jl9/i ZBwskCVOaC+MtI0/kVEkSt04bh6AvlqrBnVMVPjbTHUxlKh9p76XAy5hDnhu+wfp D+es3GX+4LnjJ1z2MfUfX5/jLnkxgidHX+YXPZP0WEvdISSqVlrmHWu0ug51tGAG Df1tN/XuaCUVlwYsNU9aZ2gzaAme9DN6tkh6WJW4ROUC6Jhx4OONl9f5ftM7yDLW NGJf7MyOjED5NP+lBX6UIT+/FDIdfbY37sI6KQoCBB4lZaaU76XzrYmpisc47aJ2 pTypD5ObVr2QfN6gPeQJ1bPeQw2dDU50NeBT5N3IS7aVnBrZoyK/gjeadqZJ+w+g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrledvgdefudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfufhvvghn ucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrth htvghrnhepgfeigeeiffeuhfettdejgfetjeetfeelfefgfefgvddvtdfghfffudehvdef keffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh hvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 88F56274042E; Wed, 15 Dec 2021 06:34:51 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4524-g5e5d2efdba-fm-20211214.001-g5e5d2efd Mime-Version: 1.0 Message-Id: In-Reply-To: <20211215112935.238561-1-marcan@marcan.st> References: <20211215112935.238561-1-marcan@marcan.st> Date: Wed, 15 Dec 2021 12:34:31 +0100 From: "Sven Peter" To: "Hector Martin" Cc: "Alyssa Rosenzweig" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 15, 2021, at 12:29, Hector Martin wrote: > This doesn't make any sense as a module since it is a critical device, > and it turns out of_phandle_iterator_args was not exported so the module > version doesn't build anyway. > > Signed-off-by: Hector Martin I think it'd be nice to add Reported-by: kernel test robot here since their service found it and maybe also a Fixes: tag. Reviewed-by: Sven Peter Sven