Sender: Guenter Roeck <groeck7@gmail.com>
To:     Arseny Demidov <arsdemal@gmail.com>
Cc:     Arseny Demidov <a.demidov@yadro.com>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211215113023.2945-1-a.demidov@yadro.com>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo
Message-ID: <0baa6133-5903-ffd8-69a0-99fb9f69665d@roeck-us.net>
Date:   Wed, 15 Dec 2021 03:59:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211215113023.2945-1-a.demidov@yadro.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/15/21 3:30 AM, Arseny Demidov wrote:
> In the file mr75203.c we have a macro named
> POWER_DELAY_CYCLE_256, the correct value should be 0x100
> 

How do you know that ? Do you have access to the datasheet, or
is it just an assumption based on the name of the define ?

Guenter

> Signed-off-by: Arseny Demidov <a.demidov@yadro.com>
> ---
>   drivers/hwmon/mr75203.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 868243dba1ee..1ba1e3145969 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -93,7 +93,7 @@
>   #define VM_CH_REQ	BIT(21)
>   
>   #define IP_TMR			0x05
> -#define POWER_DELAY_CYCLE_256	0x80
> +#define POWER_DELAY_CYCLE_256	0x100
>   #define POWER_DELAY_CYCLE_64	0x40
>   
>   #define PVT_POLL_DELAY_US	20
>