MIME-Version: 1.0
References: <CO6PR10MB56353FD77836D5605CDDB8DEDD769@CO6PR10MB5635.namprd10.prod.outlook.com>
 <20211215075258.442930-1-chi.minghao@zte.com.cn>
In-Reply-To: <20211215075258.442930-1-chi.minghao@zte.com.cn>
From:   Zhu Yanjun <zyjzyj2000@gmail.com>
Date:   Wed, 15 Dec 2021 20:36:15 +0800
Message-ID: <CAD=hENdjPT7PeMe8AoeQXQr-Ksj8S08N4xeL_=__VEsoPDeOmw@mail.gmail.com>
Subject: Re: [PATCH for-next v2] RDMA/rxe: remove redundant err variable
To:     cgel.zte@gmail.com
Cc:     devesh.s.sharma@oracle.com, chi.minghao@zte.com.cn,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        LKML <linux-kernel@vger.kernel.org>,
        RDMA mailing list <linux-rdma@vger.kernel.org>,
        zealci@zte.com.cn
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 15, 2021 at 3:53 PM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value directly instead of taking this
> in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Thanks.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun

> ---
>  drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
>
>  int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)
>  {
> -       int err;
>         unsigned char ll_addr[ETH_ALEN];
>
>         ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> -       err = dev_mc_add(rxe->ndev, ll_addr);
>
> -       return err;
> +       return dev_mc_add(rxe->ndev, ll_addr);
>  }
>
>  int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)
>  {
> -       int err;
>         unsigned char ll_addr[ETH_ALEN];
>
>         ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> -       err = dev_mc_del(rxe->ndev, ll_addr);
>
> -       return err;
> +       return dev_mc_del(rxe->ndev, ll_addr);
>  }
>
>  static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1
>