Date:   Wed, 15 Dec 2021 14:14:39 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        David Heidelberg <david@ixit.cz>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Anton Bambura <jenneron@protonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@gmail.com>,
        Nikola Milosavljevic <mnidza@outlook.com>,
        Ion Agorria <ion@agorria.com>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Ihor Didenko <tailormoon@rambler.ru>,
        Andreas Westman Dorcsak <hedmoo@yahoo.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
        Jasper Korten <jja2000@gmail.com>,
        Thomas Graichen <thomas.graichen@gmail.com>,
        Stefan Eichenberger <stefan.eichenberger@toradex.com>,
        Stefan Agner <stefan@agner.ch>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 15/28] ARM: tegra: Add usb-role-switch property to USB
 OTG ports
Message-ID: <YbnqP0XAcUYc4ePy@orome>
References: <20211211211412.10791-1-digetx@gmail.com>
 <20211211211412.10791-16-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="jZPZDpo3CQ/tiVnX"
Content-Disposition: inline
In-Reply-To: <20211211211412.10791-16-digetx@gmail.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--jZPZDpo3CQ/tiVnX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Dec 12, 2021 at 12:13:59AM +0300, Dmitry Osipenko wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>=20
> If an USB port is an OTG port, then we should add the usb-role-switch
> property. Otherwise XUSB setup fails and therefore padctl is unable to
> set up the ports. This leads to broken USB and PCIe ports. Add the
> usb-role-switch properties to Tegra124 device-trees to fix the problem.
>=20
> The error message shown without this patch is e.g:
> usb2-0: usb-role-switch not found for otg mode
>=20
> [digetx@gmail.com: improved commit message]
> Tested-by: Thomas Graichen <thomas.graichen@gmail.com> # T124 Nyan Big
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 +
>  arch/arm/boot/dts/tegra124-apalis.dtsi      | 1 +
>  arch/arm/boot/dts/tegra124-nyan.dtsi        | 1 +
>  arch/arm/boot/dts/tegra124-venice2.dts      | 2 +-
>  4 files changed, 4 insertions(+), 1 deletion(-)

The device tree bindings for the XUSB pad controller say that when this
property is set, then the "connector" subnode should also exist.

Any chance we can add that? I was planning on making that a dependency
in the json-schema conversion of the binding, in which case it would be
more of a "must" than a "should".

Thierry

--jZPZDpo3CQ/tiVnX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG56j0ACgkQ3SOs138+
s6ED/BAAjJzAFGEDZMa0RP9mEQ8ZKPoBhLPoU6TYw8zUJbImsBK004ZjQf/8+RgQ
cuy7PrKJVdVf3GbpKKyj6B+1POinwPCTOChix1LpM8hVr/Cbyo3u20CEDHHuTnDT
7ubav66bl3W5XlLLrUMShqv4mvZU75XJweJSWfnJntM01K0ozYVFJP2m9w/m4kwt
Mo4Gz/tA5Gha9GuupY3M1Nxue3uqRWBgnRoCrns6Ph6m6m/64qxIB0yP4+mnF3bl
egP7VYEXSwOeEGYX3CBgu9C6bwMh4ikY/4TAIJ5qD79rUg8Gx5zhtP0mZU85kn/S
opaDvw9cNzc80PsFLRuA3C9JzYOEi4GVca/b94iSPf7vI/2qqWZ6W6t9pmkCu0ub
Pf0JsTvs7l6+PZil1lbPmFcbQ7B+dOXFLmn2+2htt+VCN0YjRHOeduBVAwVgNTVF
GdbLQ/kLjD/zSKQ8mTXvoDiqgyEs4qa/zTEnLdiE6Mk7+vRKx3oKJb9ebjTgjDro
c1xR+/EBKuzpdTdMMfkNu1JMIbKkp4HXt1Zq/jf1q1+MdJ7ijV128T+as0+wUb6k
FUisvaWf0Winw30eBmbsbzWYstEDf9ofjTDGBuBXrlyuRtZunKe2+MszNa5aoJpg
G5m0UbGwMrhoPaXuV+F7fY0A2BH+M3+yGLAKY/REavAemMn1JtM=
=Q6N6
-----END PGP SIGNATURE-----

--jZPZDpo3CQ/tiVnX--