Message-ID: <07800ea9-e0f9-bb6a-3690-5e81772d0fd4@amd.com>
Date:   Wed, 15 Dec 2021 19:20:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH v1 01/11] i2c: Introduce common module to instantiate CCGx
 UCSI
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     Wolfram Sang <wsa@kernel.org>, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Ajay Gupta <ajayg@nvidia.com>,
        Sanket Goswami <Sanket.Goswami@amd.com>,
        "S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>
References: <20211207192159.41383-1-andriy.shevchenko@linux.intel.com>
 <a0ac314f-9e9d-7749-6f22-fd3e44372288@linux.intel.com>
 <YbeKWScx1HwCYJTs@smile.fi.intel.com>
From:   "Shah, Nehal-bakulchandra" <nehal-bakulchandra.shah@amd.com>
In-Reply-To: <YbeKWScx1HwCYJTs@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFU1dUJnQ0ZVZTFseStJVWhiREJOc21kR1FTalV3bURFaWI1S082QzJLQUk5?=
 =?utf-8?B?dHJ3S09qSDZuWEFxQTh1akN4WGtqeDdaL3dveExQSzNVSCtqYkVPRzl4K0dX?=
 =?utf-8?B?Y0RqTkdrb3RHaHpGWXRGUllDd3NMRm5rcElmMXZqRkV3dVpWRFVKWStZQTRX?=
 =?utf-8?B?M0Qyb2lIYkpqMS9MODd0R21QdWJhZDZQZGpjbTRIOExaZHpsN3FyRm1DTCtr?=
 =?utf-8?B?TUxBV2FNa1BOQUplRi9nOXFJWEpobHcyd0RSQ3JVS2YzWGdpcWtLY0crQWhz?=
 =?utf-8?B?MEhQb2pNUHY1bFdYOVU1dGk2SXEvQWRiSmYrU1YzNUpCOWdzQWlZbXgzOGlX?=
 =?utf-8?B?NXNxSU1US0RhR2loNUgzWWJCR1JHbmM2cHZEZU9kZVYzdExxcWMyNkxWY2c0?=
 =?utf-8?B?clRxVXkzT01Sc2wyTjdFZ3oySDFZck1jaFVyWFlTM1JNMWxTNkJVTGVnY0k4?=
 =?utf-8?B?NnJ6aFFJOUY1Y0xtbGU2NkQ4a1lMeEswdk93eWZWSXR1ZEUraDN3eTYwMDh3?=
 =?utf-8?B?TnMya050Q1JUU0lUNHhLZXY1Nmc5TnM1WUpSUUJ0eG1tZVVIUU1QMjMrQW1G?=
 =?utf-8?B?bnphbVoyUktiNEV4cUV4Y2VmeEs0bU9ldi9XTDVsb2ZrclNXMWdhWnJCbzNO?=
 =?utf-8?B?UUV2MmNCT3hkdjJJMThQSXBJdFNxYlFTSVdnalN4djNhbGJwR2NBVlRvZWtS?=
 =?utf-8?B?RjZFWlg1ZE9VUkIvVUJ3aFlKUFV4djdSa0hpY1o1R0hxaUJncE8yWGU0SHdJ?=
 =?utf-8?B?SWtLTW5heWZtd2JPUHowU1hFcitXbmVUZURhTnhaeXVVMVU4eUVseG4vTHJK?=
 =?utf-8?B?eElrVi8rOGRZeVBhdUxPNWZFZGdBd3ZwR0xzOFhvaTMyV2l1SnV5eS81THRa?=
 =?utf-8?B?Yy85SFIzaU5Wd0JTNyszdUtpVzc5VTJ5UEVBMWt2VEg0a3kwZzNlTHZVR281?=
 =?utf-8?B?eVdwTitCZ0N1NHBxTHdoNTNkd0pNUGZacVFySHZsRDhYMU9rWnhNM1QrcW5I?=
 =?utf-8?B?V0tTM3dpbU1RMERwV0MyVC9BM0dBOVNwL0F4UG05NmhHNGRSV3JVTHh3dktw?=
 =?utf-8?B?eG51VUEvSmpzY2M2QU9nc2QrVzl1c21kMnZpMjNHOFNHR1ZSVkVWS3RhSFFj?=
 =?utf-8?B?WEF2aVdJY00wRnZ4dURKM1UyNlprRXRhTFFXWjlOSUZkQ3hqRit0aUdoV0dv?=
 =?utf-8?B?aEFaL1dNZ2RJVEpzT2xOemFoNW1heldnRUs5bEpwY0tvT2dOSUNFK2U4bHBT?=
 =?utf-8?B?NDRaR2dzVkpNMkZWN2JZb2lkajBEUURqREN4ZnF6MkhINmRrM2cwZ0g3TTRM?=
 =?utf-8?B?U21nTC9PWVNCK1NjN1NPOWFpa2hVd1dkbHNYM0ZnTWxrQjNUS1B3RWdiUEky?=
 =?utf-8?B?VzhNSVpnN1hIQ1FsbWNIZERJN3UzaE1IdDAyclpFQVZXaksvUHlXWXdKdjRr?=
 =?utf-8?B?RkxpM2FOYjF6UFIvNmt6ai9RT1h5eWdyUUFrN25MOWxOdS8zM3IrVGZHM3dS?=
 =?utf-8?B?Zk5VWXp4RFdTNVZ5NThGSHQvSlpyd2wwU3NZOGpvenFSeEkzVG9BNkNqcC8x?=
 =?utf-8?B?eDJEa3lFOWRsYy9WK3I3NStieHpFV0ZpdHNBb3kyYUswcEpkRnJXaGJ1TDNK?=
 =?utf-8?B?bWFCWFhLRXdkY2dST3pIMkhQZWNTM3RLK0JZc2ZyZ0k5dnljK1FPZERqbDJl?=
 =?utf-8?B?WUVKaFVHR1N2Z1Q1cG85TDBaSmVmbFNZSGUrOUFWQkd5bTFTSWdZMFNxdzBi?=
 =?utf-8?B?L3NzNTRGc3hZYTZtM0NqTzUrb0tvMnVjYjZ3RjdqdnBCVGs1MjJkZklheGto?=
 =?utf-8?B?T3FzUFpOWi9jR1hMQ0xqWjZOQzhRYVUxSmhRN0hsK2ZBV1FucE8rU2k4N0JM?=
 =?utf-8?B?dVJlbnJiQ2s5UG5DNEpoQWUrYld1Z3h1bC9OSjRPWjlNS05uUFFBcHhqMHJO?=
 =?utf-8?B?dlVuMkdEM2VFaFN2anphWGc5VFNHTHJaUHo3bnJKQWc0QXJ3Y1RKa3pWR0p3?=
 =?utf-8?B?MXo3Z3cwUzhTdmFvajRpTWNBTXZIbjcrd3ZHT0xHdFduc3lwNlRvZE41TDBj?=
 =?utf-8?B?a3U5MDVlTFVwQnp2VU9TUkNwS3p1MkFJUFMwYkpvZXorRW9qTEVEYkJHc0hy?=
 =?utf-8?Q?GkIw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 570ff7a2-0d89-48ce-9d24-08d9bfd1d5ea
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4188.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2021 13:50:21.1377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G7yclI1TFBRtB97vyg7Kq1eQ4yo1bHEr356EseeaXm8j5I77+6bebKETO2NI1r/o
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2762
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

On 12/13/2021 11:30 PM, Andy Shevchenko wrote:
> On Wed, Dec 08, 2021 at 02:29:04PM +0200, Jarkko Nikula wrote:
>> On 12/7/21 21:21, Andy Shevchenko wrote:
>>> Introduce a common module to provide an API to instantiate UCSI device
>>> for Cypress CCGx Type-C controller. Individual bus drivers need to select
>>> this one on demand.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> ---
>>>    drivers/i2c/busses/Kconfig         |  7 +++++++
>>>    drivers/i2c/busses/Makefile        |  3 +++
>>>    drivers/i2c/busses/i2c-ccgx-ucsi.c | 27 +++++++++++++++++++++++++++
>>>    drivers/i2c/busses/i2c-ccgx-ucsi.h | 11 +++++++++++
>>>    4 files changed, 48 insertions(+)
>>>    create mode 100644 drivers/i2c/busses/i2c-ccgx-ucsi.c
>>>    create mode 100644 drivers/i2c/busses/i2c-ccgx-ucsi.h
>>>
>> I've mixed feelings about this set. I'd either put patches 3-8 first since
>> e.g. 6/11 and 8/11 are fixing existing issues or even better to split CCGx
>> UCSI stuff into another set.
> 
> I have sent v2 with DesignWare patches only and no conversion part included.
> 

It will be good we can take this patch also in this series. This is more 
nicer and cleaner solution. That said, we are working futuristic 
platform where CCGX is connected over system  i2c of our platform i.e 
AMDI0010 so in this case from designware platform i2c driver we will 
have to probe the CCGX driver.

Regards
Nehal