Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9223C433F5 for ; Wed, 15 Dec 2021 13:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243051AbhLON5Z (ORCPT ); Wed, 15 Dec 2021 08:57:25 -0500 Received: from mga11.intel.com ([192.55.52.93]:7483 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237608AbhLON5X (ORCPT ); Wed, 15 Dec 2021 08:57:23 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10198"; a="236766359" X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="236766359" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 05:57:22 -0800 X-IronPort-AV: E=Sophos;i="5.88,207,1635231600"; d="scan'208";a="614708573" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2021 05:57:21 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mxUlc-006ciu-8l; Wed, 15 Dec 2021 15:56:24 +0200 Date: Wed, 15 Dec 2021 15:56:24 +0200 From: Andy Shevchenko To: Brendan Higgins Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2 1/1] kunit: Replace kernel.h with the necessary inclusions Message-ID: References: <20211213204441.56204-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 14, 2021 at 04:56:21PM -0500, Brendan Higgins wrote: > On Mon, Dec 13, 2021 at 3:44 PM Andy Shevchenko > wrote: > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > > > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Brendan Higgins > Tested-by: Brendan Higgins Thanks! > > Andrew, please take it through your tree since KUnit maintainer is non-responsive > > by unknown (to me) reasons. > > Sorry, I did not see the previous version of this patch. Maybe you need to check your email settings and your domain MTA? https://lore.kernel.org/linux-kselftest/20211110103552.60181-1-andriy.shevchenko@linux.intel.com/T/#u > But this > looks fine, and does not appear to break any tests. -- With Best Regards, Andy Shevchenko