Date:   Wed, 15 Dec 2021 15:01:25 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        David Heidelberg <david@ixit.cz>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Anton Bambura <jenneron@protonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@gmail.com>,
        Nikola Milosavljevic <mnidza@outlook.com>,
        Ion Agorria <ion@agorria.com>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Ihor Didenko <tailormoon@rambler.ru>,
        Andreas Westman Dorcsak <hedmoo@yahoo.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
        Jasper Korten <jja2000@gmail.com>,
        Thomas Graichen <thomas.graichen@gmail.com>,
        Stefan Eichenberger <stefan.eichenberger@toradex.com>,
        Stefan Agner <stefan@agner.ch>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 11/28] ARM: tegra: Add device-tree for ASUS
 Transformer Infinity TF700T
Message-ID: <Ybn1Ne2aGfsablwQ@orome>
References: <20211211211412.10791-1-digetx@gmail.com>
 <20211211211412.10791-12-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="4QNYjcTi513a/zhS"
Content-Disposition: inline
In-Reply-To: <20211211211412.10791-12-digetx@gmail.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--4QNYjcTi513a/zhS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Dec 12, 2021 at 12:13:55AM +0300, Dmitry Osipenko wrote:
[...]
> +		i2c@1 {
> +			reg = <1>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			dsi-bridge@7 {
> +				compatible = "toshiba,tc358768";
> +				reg = <0x7>;
> +
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				clocks = <&tc358768_osc>;
> +				clock-names = "refclk";
> +
> +				reset-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
> +
> +				vddc-supply = <&vdd_1v2_mipi>;
> +				vddio-supply = <&vdd_1v8_vio>;
> +				vddmipi-supply = <&vdd_1v2_mipi>;
> +
> +				ports {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +
> +					port@0 {
> +						reg = <0>;
> +
> +						bridge_input: endpoint {
> +							remote-endpoint = <&dpi_output>;
> +							data-lines = <24>;
> +						};
> +					};
> +
> +					port@1 {
> +						reg = <1>;
> +
> +						bridge_output: endpoint {
> +							remote-endpoint = <&panel_input>;
> +						};
> +					};
> +				};
> +
> +				/*
> +				 * Panasonic VVX10F004B00 or HYDIS HV101WU1-1E1
> +				 * LCD SuperIPS+ Full HD panel.
> +				 */
> +				panel@1 {
> +					compatible = "panasonic,vvx10f004b00";
> +					reg = <1>;
> +
> +					power-supply = <&vdd_pnl>;
> +					backlight = <&backlight>;
> +
> +					port {
> +						panel_input: endpoint {
> +							remote-endpoint = <&bridge_output>;
> +						};
> +					};
> +				};

make dtbs_check complains about this and says that panel@1 (as well as
#address-cells and #size-cells) are not allowed here. And indeed the
binding for the Toshiba bridge doesn't mention them here.

Do we need this here or should this be moved to the top level to fix
those warnings? I guess what you're doing above is describe a DSI bus
created by the DSI bridge, which also makes sense, so another
alternative would be to fix up the binding and let it accept those
properties.

Thierry

--4QNYjcTi513a/zhS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG59TIACgkQ3SOs138+
s6HD1xAAm8DaT6So1msIwtUIXskigng+5eBeQ9njOhvT4GBKLPRjs+0ihBXmOcV/
Oyd4ndaEEtIE2rRFZbNo2nq2Z1SFNu3f8p3NuKU3Co/KPhjxLRFI79lFMgbAUr1z
Dbzwb9EZZc+dUgnBpxNoqsaRzHju8g6iimZIqLqoOksXI3vHwt/g4PjIM+Y2mlsm
xIQKuDq6AkKMGIXMt1uDw+FF4lvDaZqHaWLg1KkKBpk6K0jO1ddxuAreWSWKYVZP
hsMMePHdeOVmEoAus8Kmp3VIVlF9fMsLnHnMLDF+8CCvSGi4f7xkB5WH8cVl1Bfj
8d4sG4mVZckaJjOaJB0satdnEKJ1KtrUE4RyyHm9+v3Dn2+mSP0VWQvYeneULfWZ
ycE/29J7p2QJhymlH4Z90W5q67S8JGFOLirI5I7MZvRr+sps15tBMq30tMZ4JhLV
Pn5woWxsp6YdrzmdK2iDMi+XWlm+uT733AL3jH6dnO1KKqZXJK3lwh3strGnG/V1
NjxOhOISfXuMf0eBF9OQxnKgofNgViicXsPn156Wjn8rcrgEj7JAEDR+HDluOGcl
e7ZqUzvFvT8BVu2ZK04O1DhrG1dhITln7PCx9WcMR56tgO9jzUstjoGGWKeXLtkL
jjd+l0jotMpw8p8QQTxh5ay7yp0W3Zu82mgtM3brn5NwCHSQUQ4=
=c3xm
-----END PGP SIGNATURE-----

--4QNYjcTi513a/zhS--