Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058D2C433EF for ; Wed, 15 Dec 2021 14:02:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234687AbhLOOCW (ORCPT ); Wed, 15 Dec 2021 09:02:22 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:40384 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243122AbhLOOCV (ORCPT ); Wed, 15 Dec 2021 09:02:21 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BFBDE618FB; Wed, 15 Dec 2021 14:02:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3B76C34604; Wed, 15 Dec 2021 14:02:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1639576940; bh=gjJDfN4/cwB6Q6D83aEK1EKtI3r4pBKQK7vK6fns9kk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PoOscxMO+sVvikJP4LXu4/0jpqIWAE5DP2d35uAR1yZrRBvK/Cffyq+NujzUeKLfQ ifPtaJrL/6qTapFVRUrwgO8eVYHrMWwa/rL9vD2/vZqdvtzx9xyAOzSN6+UIKpnjLo Rr3MxilQmtuxcjhBr17n4CJ/roYV70fmX783KWnE= Date: Wed, 15 Dec 2021 15:02:17 +0100 From: Greg KH To: Mark-PK Tsai Cc: stable@vger.kernel.org, rppt@kernel.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@armlinux.org.uk, rppt@linux.ibm.com, tony@atomide.com, wangkefeng.wang@huawei.com, yj.chiang@mediatek.com Subject: Re: [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Message-ID: References: <20211213085710.28962-1-mark-pk.tsai@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 13, 2021 at 10:07:40AM +0100, Greg KH wrote: > On Mon, Dec 13, 2021 at 04:57:05PM +0800, Mark-PK Tsai wrote: > > When linux memory is not aligned with page block size and have hole in zone, > > the 5.4-lts arm kernel might crash in move_freepages() as Kefen Wang reported in [1]. > > Backport the upstream fix commits by Mike Rapoport [2] to 5.4 can fix this issue. > > > > And free_unused_memmap() of arm and arm64 are moved to generic mm/memblock in > > the below upstream commit, so I applied the first two patches to free_unused_memmap() > > in arch/arm/mm/init.c. > > > > (4f5b0c178996 arm, arm64: move free_unused_memmap() to generic mm) > > > > [1] https://lore.kernel.org/lkml/2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com/ > > [2] https://lore.kernel.org/lkml/20210630071211.21011-1-rppt@kernel.org/#t > > > > Mike Rapoport (5): > > memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER > > memblock: align freed memory map on pageblock boundaries with > > SPARSEMEM > > memblock: ensure there is no overflow in memblock_overlaps_region() > > arm: extend pfn_valid to take into account freed memory map alignment > > arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM > > > > arch/arm/mm/init.c | 37 +++++++++++++++++++++++++------------ > > arch/arm/mm/ioremap.c | 4 +++- > > mm/memblock.c | 3 ++- > > 3 files changed, 30 insertions(+), 14 deletions(-) > > > > -- > > 2.18.0 > > > > These look like they also are required in 5.10.y as well, right? Please > also provide a backported series for that tree, we can not have users > moving to a newer kernel version and having regressions. > > I can't take this series until then, sorry. Ah, now I see your 5.10 series, thanks. I'll go queue both of these series up now, thanks for the backports. greg k-h