Message-ID: <1a3928c8-cc3a-c1b4-335d-0efdcd227d32@linux.intel.com>
Date:   Wed, 15 Dec 2021 16:15:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.0
Subject: Re: [PATCH v2 1/6] i2c: designware-pci: Use temporary variable for
 struct device
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>
References: <20211213180034.30929-1-andriy.shevchenko@linux.intel.com>
 <3d67442c-87a7-e05b-7f69-de501fc0ad29@linux.intel.com>
 <YbnyQcpAXxSs9R2K@smile.fi.intel.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <YbnyQcpAXxSs9R2K@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/15/21 15:48, Andy Shevchenko wrote:
>> Yet another differently named
>> "device" pointer more to the mess (Inconsistent naming use of struct
>> dw_i2c_dev *dev, struct dw_i2c_dev *i_dev and struct device *dev in the
>> i2c-designware-*).
> 
> As I said, please fix this inconsistency yourself how you find it better
> and I will use that in the future contributions.
> 
I've been saving it for some new comer who is looking for first kernel 
contribution tasks :-)

Jarkko