Message-ID: <9949baad-fc59-475c-cb7d-a4da935b8271@linux.intel.com>
Date:   Wed, 15 Dec 2021 16:21:15 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.4.0
Subject: Re: [PATCH v2 4/6] i2c: designware-pci: Fix to change data types of
 hcnt and lcnt parameters
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
References: <20211213180034.30929-1-andriy.shevchenko@linux.intel.com>
 <20211213180034.30929-4-andriy.shevchenko@linux.intel.com>
 <05baeea4-08ef-4fcd-5004-58b19e3e63f3@linux.intel.com>
 <Ybny5Cxh60e7d63q@smile.fi.intel.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <Ybny5Cxh60e7d63q@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/15/21 15:51, Andy Shevchenko wrote:
> On Wed, Dec 15, 2021 at 09:55:47AM +0200, Jarkko Nikula wrote:
>> On 12/13/21 20:00, Andy Shevchenko wrote:
>>> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
>>>
>>> The data type of hcnt and lcnt in the struct dw_i2c_dev is of type u16.
>>> It's better to have same data type in struct dw_scl_sda_cfg as well.
> 
> ...
> 
>> I proposed this to be first before questionable cleanups since this fixes
>> existing confusion (noted by Wolfram not any of us). Same to 5-6/6.
> 
> Okay, I postpone this series. It seems altogether it will require more time
> than I currently have. Consider picking patches on the basis you have in mind
> if you consider them useful. Thanks!
> 
Will do. I really like to get those patches before any cosmetic changes 
that fix existing issues that were confusing all of us (patches 4/6 and 
6/6) and do obvious cleanup (3/6 and 5/6).

Jarkko