Subject: Re: [PATCH v6 11/28] ARM: tegra: Add device-tree for ASUS Transformer
 Infinity TF700T
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        David Heidelberg <david@ixit.cz>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Anton Bambura <jenneron@protonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@gmail.com>,
        Nikola Milosavljevic <mnidza@outlook.com>,
        Ion Agorria <ion@agorria.com>,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Ihor Didenko <tailormoon@rambler.ru>,
        Andreas Westman Dorcsak <hedmoo@yahoo.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
        Jasper Korten <jja2000@gmail.com>,
        Thomas Graichen <thomas.graichen@gmail.com>,
        Stefan Eichenberger <stefan.eichenberger@toradex.com>,
        Stefan Agner <stefan@agner.ch>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211211211412.10791-1-digetx@gmail.com>
 <20211211211412.10791-12-digetx@gmail.com> <Ybn1Ne2aGfsablwQ@orome>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <02d7e9a9-6999-cccd-aea2-d069c759cd56@gmail.com>
Date:   Wed, 15 Dec 2021 17:52:24 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <Ybn1Ne2aGfsablwQ@orome>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

15.12.2021 17:01, Thierry Reding пишет:
> On Sun, Dec 12, 2021 at 12:13:55AM +0300, Dmitry Osipenko wrote:
> [...]
>> +		i2c@1 {
>> +			reg = <1>;
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			dsi-bridge@7 {
>> +				compatible = "toshiba,tc358768";
>> +				reg = <0x7>;
>> +
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				clocks = <&tc358768_osc>;
>> +				clock-names = "refclk";
>> +
>> +				reset-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
>> +
>> +				vddc-supply = <&vdd_1v2_mipi>;
>> +				vddio-supply = <&vdd_1v8_vio>;
>> +				vddmipi-supply = <&vdd_1v2_mipi>;
>> +
>> +				ports {
>> +					#address-cells = <1>;
>> +					#size-cells = <0>;
>> +
>> +					port@0 {
>> +						reg = <0>;
>> +
>> +						bridge_input: endpoint {
>> +							remote-endpoint = <&dpi_output>;
>> +							data-lines = <24>;
>> +						};
>> +					};
>> +
>> +					port@1 {
>> +						reg = <1>;
>> +
>> +						bridge_output: endpoint {
>> +							remote-endpoint = <&panel_input>;
>> +						};
>> +					};
>> +				};
>> +
>> +				/*
>> +				 * Panasonic VVX10F004B00 or HYDIS HV101WU1-1E1
>> +				 * LCD SuperIPS+ Full HD panel.
>> +				 */
>> +				panel@1 {
>> +					compatible = "panasonic,vvx10f004b00";
>> +					reg = <1>;
>> +
>> +					power-supply = <&vdd_pnl>;
>> +					backlight = <&backlight>;
>> +
>> +					port {
>> +						panel_input: endpoint {
>> +							remote-endpoint = <&bridge_output>;
>> +						};
>> +					};
>> +				};
> 
> make dtbs_check complains about this and says that panel@1 (as well as
> #address-cells and #size-cells) are not allowed here. And indeed the
> binding for the Toshiba bridge doesn't mention them here.
> 
> Do we need this here or should this be moved to the top level to fix
> those warnings? I guess what you're doing above is describe a DSI bus
> created by the DSI bridge, which also makes sense, so another
> alternative would be to fix up the binding and let it accept those
> properties.

Toshiba bridge binding is incomplete. David has patch for that [1], I
don't think that it was sent out yet.

[1]
https://github.com/okias/linux/commit/0875230062294b6db17f395ced0a8384a4c1cfc7