From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Oleksij Rempel <o.rempel@pengutronix.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>
Subject: RE: [BUG] net: phy: genphy_loopback: add link speed configuration
Thread-Topic: [BUG] net: phy: genphy_loopback: add link speed configuration
Thread-Index: AdfwtmkvCyrAW5M4S3mERBKDxICdHAAGBHqAADANSQAAAa06AAAAYHXgAAC+sIAACnbKwA==
Date:   Wed, 15 Dec 2021 15:03:52 +0000
Message-ID: <CO1PR11MB47710EE8587C6F4A4D40851ED5769@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <CO1PR11MB4771251E6D2E59B1B413211FD5759@CO1PR11MB4771.namprd11.prod.outlook.com>
 <YbhmTcFITSD1dOts@lunn.ch>
 <CO1PR11MB477111F4B2AF4EFA61D9B7F4D5769@CO1PR11MB4771.namprd11.prod.outlook.com>
 <Ybm0Bgclc0FP/Q3f@lunn.ch>
 <CO1PR11MB47715A9B7ADB8AF36066DCE6D5769@CO1PR11MB4771.namprd11.prod.outlook.com>
 <Ybm7jVwNfj01b7S4@lunn.ch>
In-Reply-To: <Ybm7jVwNfj01b7S4@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oip6Ew1cF9A15rUjadBb3Cd60Vn0KCRAlKFI3nEjyFnf50ga+LX6SsgqctSW?=
 =?us-ascii?Q?F/kc7O/obCONIXNdEUkGdpS76GpdasiL4dEGEfPc3Tgn657iNeyclz7MNZo4?=
 =?us-ascii?Q?OYo8xJEPAbsokss3yeGSjtwHvcXe4zWBWPeKjJios6IH5gaG2+0VXK+VU6xs?=
 =?us-ascii?Q?i1HNA2+59rou7VyyR208scxKCWMqVa9DtPj3rilMZD57lujsntR6GEGSSdTf?=
 =?us-ascii?Q?v645BbqdXgD+wl9AoqBVI1LJt2mPWjrj3e1bitikcrCQodcHhMiGT39esFFQ?=
 =?us-ascii?Q?DhReXYGg055kFfBXqHfV0/1UQItBOwzkeE1gAALejjYUMH29RQvkMsYVANTC?=
 =?us-ascii?Q?wlYA7zDGPuZXMm7Qwzsm//pyoTDtI2yN/sEoQiK3DL81csLIzpmAKeiZDaiB?=
 =?us-ascii?Q?loTRMqwRZFgGRrXigNZUyv/JAf0rJUfDkj0xYhsn/WkJd6+uIOCAAX9weeMp?=
 =?us-ascii?Q?nZ8stmzYXt1g+Bp/NBF5hSYaxHV6Mtn1kprZu7I0hFOy4mtjtin82uHFK4x2?=
 =?us-ascii?Q?h3ThyFKHFa3WkmMrw5dvnGs+rBuaOuXbe0ibEY1WIddpK6729cE/gPqMiR/P?=
 =?us-ascii?Q?PErxJq65EfL49jm9Qh1ZkK6S4xnTfkdSizUh4dvw+bTZHA+NmVWLT5AoRsQT?=
 =?us-ascii?Q?OCcXtV3xo7TSwq1xEEVFB1lHdt72vCtbZ9OBcFKhbvZVqlRFce9DUWR2N7W3?=
 =?us-ascii?Q?W9uZXCTLgl80B8e9dGVggSjFnsxWwbPEA7Uelev85X6RAh0FwB10O90TcxRl?=
 =?us-ascii?Q?CV+3BqStK25IIMkMPIKRTOWTcEQA0nMsS8WAtQ8Q+AZhGYXSKYi14pkw3pDq?=
 =?us-ascii?Q?D21dCl1hrRH0coiVnvOX3ybNQUcKxTHao//1WApzdvMhKVHAZSai+yCNnX+u?=
 =?us-ascii?Q?OrTSM9o7Uvwx6SjAa96c8NamK4UujDr1RSLok4jwMD81+RZ9zH9+tDqp1fsh?=
 =?us-ascii?Q?c2KLkZErJx2Nbt8liyQoQ07AyUa9rK2YETwktpoeS7r0LXqYii9ZhpRzDUcR?=
 =?us-ascii?Q?WJPa7jIw1tKEU43jZv6I4aFAn3Vq6GXtMHe5YkYfUuzSyUIDyq4WAEdNviT4?=
 =?us-ascii?Q?fLWPvkwIh7cICRwkLZktj10nzXGVZRLEoLiUu+S3wbrdj1nglM2ZrJEoDpP1?=
 =?us-ascii?Q?dAdeLcL2Xyn4aU5CdywJg5+oXD6CWkS11NLWaazOcwYmzvJaTKq/nTjkhvBa?=
 =?us-ascii?Q?iA0NJ6aN8D5N/OWmz/chO6MywNXNQibsut3vPdI0yzsv6Q3mb6ZsToaeNnKA?=
 =?us-ascii?Q?M0TgIwhMXAYf54m933TLDDasl9HnZL5gobJvVvEbpe9dG1z/7KH3KpqVmry0?=
 =?us-ascii?Q?ankhY4x+LdGeLmanTO4iL+8EtW1TAznUNBXeVgL+wnMmU1G3t4POwW1SOp7A?=
 =?us-ascii?Q?mjkZ1EFrpqeo8bodd7+//j2LWheW7RBTFiLlInfIt1VETuF32RD9LnR/2ZEF?=
 =?us-ascii?Q?Wt2k877VJA5Pnjj+kpUM0AYXDO5hQIwmi0EqxAsSpluiI+QhNn3QRrVW+hqN?=
 =?us-ascii?Q?+kYOIlaXUd6KaBA1M+Zrzt5fRMCesKmT4svxHYNry986J77rSIL4HP7yPibx?=
 =?us-ascii?Q?HqNmNQOYaJwWtVK/FJ6prYcIZZY5Yc/iYrbNZRVRY2cUOUjrj/DyDzFeOejC?=
 =?us-ascii?Q?Y9f0iyk+8MiKV0DUYjzLc3NFA5b7+U64CM+LTfo2Igx5upvKmtH0Eyk5YjbM?=
 =?us-ascii?Q?w3WiFOqkZSPMHnCnocdHIZK6zwKMxYJySaAP6fSx/i4Reh/G?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c9bc89a-9e4c-4970-f1b2-08d9bfdc1ba0
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2021 15:03:52.5036
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1wh90lolYo5wwAWRFdBbglsxWA2C0FlPkHFC4rLy5yrBBWrwa3ohq4QjTjNm0lMlMR8d5y4kPO0af41bbNaPqX9XRB2w/qi3munJI46ZOhWyiUP5i6mRcdbsCXq2u/D9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1792
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, December 15, 2021 5:55 PM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org; Voon, Weifeng <weifeng.voon@intel.com>;
> Wong, Vee Khee <vee.khee.wong@intel.com>
> Subject: Re: [BUG] net: phy: genphy_loopback: add link speed configuratio=
n
>=20
> > > -----Original Message-----
> > > From: Andrew Lunn <andrew@lunn.ch>
> > > Sent: Wednesday, December 15, 2021 5:23 PM
> > > To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> > > Cc: Oleksij Rempel <o.rempel@pengutronix.de>;
> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Voon, Weifeng
> > > <weifeng.voon@intel.com>; Wong, Vee Khee
> <vee.khee.wong@intel.com>
> > > Subject: Re: [BUG] net: phy: genphy_loopback: add link speed
> > > configuration
> > >
> > > > Thanks for the suggestion. The proposed solution also doesn't
> > > > work. Still
> > > get -110 error.
> > >
> > > Please can you trace where this -110 comes from. Am i looking at the
> > > wrong poll call?
> >
> > I did read the ret value from genphy_soft_reset() and
> phy_read_poll_timeout().
> > The -110 came from phy_read_poll_timeout().
>=20
> O.K.
>=20
> Does the PHY actually do loopback, despite the -110?

As Intel Elkhart Lake is using stmmac driver, in stmmac_selftest, return va=
lue of phy_loopback() is checked as well. If it return -110, the selftest t=
hat using PHY loopback will be recorded as -110 (fail).

>=20
> I'm wondering if we should ignore the return value from
> phy_read_poll_timeout().

Removing/ignoring the return value from phy_read_poll_timeout() can work. B=
ut, the -110 error message will be displayed in dmesg. It is because there =
is phydev_err() as part of phy_read_poll_timeout() definition.

-Athari-

>=20
> 	Andrew