Date:   Wed, 15 Dec 2021 16:19:19 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        David Heidelberg <david@ixit.cz>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Anton Bambura <jenneron@protonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@gmail.com>,
        Nikola Milosavljevic <mnidza@outlook.com>,
        Ion Agorria <ion@agorria.com>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Ihor Didenko <tailormoon@rambler.ru>,
        Andreas Westman Dorcsak <hedmoo@yahoo.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
        Jasper Korten <jja2000@gmail.com>,
        Thomas Graichen <thomas.graichen@gmail.com>,
        Stefan Eichenberger <stefan.eichenberger@toradex.com>,
        Stefan Agner <stefan@agner.ch>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 11/28] ARM: tegra: Add device-tree for ASUS
 Transformer Infinity TF700T
Message-ID: <YboHd6tIUrl+LJQb@orome>
References: <20211211211412.10791-1-digetx@gmail.com>
 <20211211211412.10791-12-digetx@gmail.com>
 <Ybn1Ne2aGfsablwQ@orome>
 <02d7e9a9-6999-cccd-aea2-d069c759cd56@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="icIo6y0Y+9SyroLX"
Content-Disposition: inline
In-Reply-To: <02d7e9a9-6999-cccd-aea2-d069c759cd56@gmail.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--icIo6y0Y+9SyroLX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 15, 2021 at 05:52:24PM +0300, Dmitry Osipenko wrote:
> 15.12.2021 17:01, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Sun, Dec 12, 2021 at 12:13:55AM +0300, Dmitry Osipenko wrote:
> > [...]
> >> +		i2c@1 {
> >> +			reg =3D <1>;
> >> +			#address-cells =3D <1>;
> >> +			#size-cells =3D <0>;
> >> +
> >> +			dsi-bridge@7 {
> >> +				compatible =3D "toshiba,tc358768";
> >> +				reg =3D <0x7>;
> >> +
> >> +				#address-cells =3D <1>;
> >> +				#size-cells =3D <0>;
> >> +
> >> +				clocks =3D <&tc358768_osc>;
> >> +				clock-names =3D "refclk";
> >> +
> >> +				reset-gpios =3D <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
> >> +
> >> +				vddc-supply =3D <&vdd_1v2_mipi>;
> >> +				vddio-supply =3D <&vdd_1v8_vio>;
> >> +				vddmipi-supply =3D <&vdd_1v2_mipi>;
> >> +
> >> +				ports {
> >> +					#address-cells =3D <1>;
> >> +					#size-cells =3D <0>;
> >> +
> >> +					port@0 {
> >> +						reg =3D <0>;
> >> +
> >> +						bridge_input: endpoint {
> >> +							remote-endpoint =3D <&dpi_output>;
> >> +							data-lines =3D <24>;
> >> +						};
> >> +					};
> >> +
> >> +					port@1 {
> >> +						reg =3D <1>;
> >> +
> >> +						bridge_output: endpoint {
> >> +							remote-endpoint =3D <&panel_input>;
> >> +						};
> >> +					};
> >> +				};
> >> +
> >> +				/*
> >> +				 * Panasonic VVX10F004B00 or HYDIS HV101WU1-1E1
> >> +				 * LCD SuperIPS+ Full HD panel.
> >> +				 */
> >> +				panel@1 {
> >> +					compatible =3D "panasonic,vvx10f004b00";
> >> +					reg =3D <1>;
> >> +
> >> +					power-supply =3D <&vdd_pnl>;
> >> +					backlight =3D <&backlight>;
> >> +
> >> +					port {
> >> +						panel_input: endpoint {
> >> +							remote-endpoint =3D <&bridge_output>;
> >> +						};
> >> +					};
> >> +				};
> >=20
> > make dtbs_check complains about this and says that panel@1 (as well as
> > #address-cells and #size-cells) are not allowed here. And indeed the
> > binding for the Toshiba bridge doesn't mention them here.
> >=20
> > Do we need this here or should this be moved to the top level to fix
> > those warnings? I guess what you're doing above is describe a DSI bus
> > created by the DSI bridge, which also makes sense, so another
> > alternative would be to fix up the binding and let it accept those
> > properties.
>=20
> Toshiba bridge binding is incomplete. David has patch for that [1], I
> don't think that it was sent out yet.
>=20
> [1]
> https://github.com/okias/linux/commit/0875230062294b6db17f395ced0a8384a4c=
1cfc7

Okay, please make sure this finds its way upstream eventually. That
patch looks quite similar to what I tried to do to fix this up locally.

Thierry

--icIo6y0Y+9SyroLX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG6B3YACgkQ3SOs138+
s6Gxtw//aCvOf0bKYvoVKs4ZCTS+T/XQeMyl3xrlo066OnC/8FgVPWQBxCWdpg6F
w0cDvawYI5tNIb+X4BGzTiD7HMySlaLhxm+UHhBg6CF/LbMIi4b5iY1QI/6djQhW
98bosskqCFmL00X5NlYZClfloYh2N8XuVXWujQtFzH0H4uuTfAxCidHwEibkynbO
TAuqMWZR9W4IqX5lzaCdsyr2Eb6VZ94TiYskuBouICCUjNLrgAwxxU/ngCZQzweD
sGTxjWjIkvsO5xoXUFJi3G0+GjHEk20AGFi1CDl1+2/EIAUWheoYfS5sphPWIMWN
wFbWZl9F5HVbAspGTI6rf0Z6mmU2vNAaUs+9KKmvhYGVL2XTws6hmtujh0dpb8mc
9e15sImNz2StsDUwufeg44+XJaqTNy4ir1qzLrMk1KMsMh3K5gqYh5J+pjmvzzJs
ec4OQeJ2F6Aj+7BDN/PLvbwn8sYfl/Ll8/dxk/00/PqhhROx6tGKNY0Xh63gHHJY
d2MbsGe0JOAHtl9Yeu/wSzVw7xP+J1nTN/us8FzPLv5ZElAlySzdW0I6Eg6825WR
qG8oD73IV0DNwCa2xcmutblU6T4JyhDRq641qXWscChlXnTvF+s8d2el9ww5KEm+
vDWlbOfwupfkuDlg1GtF9Dco7NtebMLTOgakzSWR8DRhNrBCgoo=
=xXhW
-----END PGP SIGNATURE-----

--icIo6y0Y+9SyroLX--