Date:   Wed, 15 Dec 2021 16:52:36 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        David Heidelberg <david@ixit.cz>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        Anton Bambura <jenneron@protonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@gmail.com>,
        Nikola Milosavljevic <mnidza@outlook.com>,
        Ion Agorria <ion@agorria.com>,
        =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>,
        Ihor Didenko <tailormoon@rambler.ru>,
        Andreas Westman Dorcsak <hedmoo@yahoo.com>,
        Maxim Schwalm <maxim.schwalm@gmail.com>,
        Raffaele Tranquillini <raffaele.tranquillini@gmail.com>,
        Jasper Korten <jja2000@gmail.com>,
        Thomas Graichen <thomas.graichen@gmail.com>,
        Stefan Eichenberger <stefan.eichenberger@toradex.com>,
        Stefan Agner <stefan@agner.ch>,
        Peter Geis <pgwipeout@gmail.com>, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 15/28] ARM: tegra: Add usb-role-switch property to USB
 OTG ports
Message-ID: <YboPROE47E3QBzfl@orome>
References: <20211211211412.10791-1-digetx@gmail.com>
 <20211211211412.10791-16-digetx@gmail.com>
 <YbnqP0XAcUYc4ePy@orome>
 <9cf23721-db53-830a-f634-d2215232f059@gmail.com>
 <YboGxZSi13OGByUQ@orome>
 <8c0defff-3348-6f97-6bd4-ddfc6117e707@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bL/7g93/IKUyyp+l"
Content-Disposition: inline
In-Reply-To: <8c0defff-3348-6f97-6bd4-ddfc6117e707@gmail.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--bL/7g93/IKUyyp+l
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 15, 2021 at 06:45:32PM +0300, Dmitry Osipenko wrote:
> 15.12.2021 18:16, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > On Wed, Dec 15, 2021 at 06:04:54PM +0300, Dmitry Osipenko wrote:
> >> 15.12.2021 16:14, Thierry Reding =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >>> On Sun, Dec 12, 2021 at 12:13:59AM +0300, Dmitry Osipenko wrote:
> >>>> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> >>>>
> >>>> If an USB port is an OTG port, then we should add the usb-role-switch
> >>>> property. Otherwise XUSB setup fails and therefore padctl is unable =
to
> >>>> set up the ports. This leads to broken USB and PCIe ports. Add the
> >>>> usb-role-switch properties to Tegra124 device-trees to fix the probl=
em.
> >>>>
> >>>> The error message shown without this patch is e.g:
> >>>> usb2-0: usb-role-switch not found for otg mode
> >>>>
> >>>> [digetx@gmail.com: improved commit message]
> >>>> Tested-by: Thomas Graichen <thomas.graichen@gmail.com> # T124 Nyan B=
ig
> >>>> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> >>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >>>> ---
> >>>>  arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 +
> >>>>  arch/arm/boot/dts/tegra124-apalis.dtsi      | 1 +
> >>>>  arch/arm/boot/dts/tegra124-nyan.dtsi        | 1 +
> >>>>  arch/arm/boot/dts/tegra124-venice2.dts      | 2 +-
> >>>>  4 files changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> The device tree bindings for the XUSB pad controller say that when th=
is
> >>> property is set, then the "connector" subnode should also exist.
> >>>
> >>> Any chance we can add that? I was planning on making that a dependency
> >>> in the json-schema conversion of the binding, in which case it would =
be
> >>> more of a "must" than a "should".
> >>
> >> I guess it will be harmless if you'll add the connector subnodes. Will
> >> you be able to create a separate patch that will add the subnodes on t=
op
> >> of this patch?
> >>
> >> Thomas Graichen says that one USB port on Nyan Big doesn't work without
> >> this patch. This is why this patch is needed essentially.
> >=20
> > Okay, I can add "dummy" connector nodes for now. I don't see how we can
> > properly set this up because as far as I can tell there's USB ID GPIO on
> > Tegra124 (seems like it's a fixed function pin) and the VBUS GPIO is
> > already used to enable the VBUS supply. The gpio-usb-b-connector binding
> > required at least one of the ID and VBUS GPIOs to be specified.
>=20
> The ID and VBUS hardware configurations are very board-specific. There
> are multiple ways of how it could implemented on Tegra.
>=20
> > On the other hand, at least Venice2 has a USB type A connector for this,
> > so I'm not even sure how that would work. I vaguely recall that the
> > Tegra20 Seaboard also had a USB type A and that it was possible to use
> > it in device mode, but I don't how that would. Nor would it be correct
> > to use the gpio-usb-b-connector compatible for that since, well, it's
> > not USB type B.
>=20
> I'm not sure whether it makes much sense to use OTG for USB type A
> connectors, normally they should be fixed to host mode.

My recollection is that those can be used in device mode as well. For
example that USB type A port on Venice2 (same as for Seaboard) can be
used for RCM, IIRC. It's possible that there's no way to detect what is
connected, though, so this may not be proper OTG.

>=20
> > I suspect that Apalis has a micro-B port, much like the Jetson TK1. My
> > understanding is that OTG doesn't work on Jetson TK1 (which is why it's
> > configured in "host" mode), so it'd be interesting to see if this can be
> > made to work on Apalis.
>=20
> Looks like the default Apalis carrier board has three type A connectors.
>=20
> https://www.toradex.com/products/carrier-board/ixora-carrier-board

I'm wondering if the best thing would be to mark all of these as "host"
for now and avoid making this look like something that it isn't. I don't
think we've ever made OTG work on these boards, so perhaps we shouldn't
assume that it works.

Thierry

--bL/7g93/IKUyyp+l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG6D0QACgkQ3SOs138+
s6E6Qw/+NI/apEThH0dvFCCilxaBp5v6FIRnx3T33dnqulelfDZQg4cJzpPwv7Rm
cDJ2gPpuP3oQZkQ5pisk2KMsb8KbBHCAxopLXjggIX/Nol5uAwKb8fFHq7PkHlzy
Vw0Foe2sl7wIpCgMxdKhOZltbELOWBma7zB1NYF/Hdu1YQlmPraexCUETqZLMM9v
QDb7oDBWS3bHJNn3KiaRTv3J/2ahOahtxzSNI4KdiXYd/4QAclKSBIo4MnQa32IV
4vwTvXb+wBTDyr+rAcyM9p2JxeH17vbYBbJlwygc4Vc7uxvCEuyQr6zfTCUgNbFB
3dOCOp1LjiDKREJ8N2R4V3DpQoE2x5Aiw0JNKNc2rFwlLBA5I8/HXnyIegYlywHz
fdXCgiNxHE60tHH9V9F1yUcnnuLN+KcGHwCYNg76aCQOagNPHsFMFrCCHFCEU41i
JLNrb7NiyjD5O+6KmcMMFPZv8XgoD15EHG3xLRzKivZhbhbCLzw5ywIaPi0FeeX4
/gGfuPU08pyohF0eZUVQ8FMG2l8RQVBIpiK2gxrRNn/bRY+UYDM86HsH/C6rZfZX
FLsyRSId1MHst37Q34gp7Nye8ZdDwb0mOhATfRUTwujNEFgLLX6bkVBwT75VzXSY
GcJS1L3y0Rtw3Gv5Qs4DquGDIuA9oXNUO0Gbf+uVgNM8ORojoN8=
=1LNN
-----END PGP SIGNATURE-----

--bL/7g93/IKUyyp+l--