Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965344AbXAYFmr (ORCPT ); Thu, 25 Jan 2007 00:42:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965345AbXAYFmr (ORCPT ); Thu, 25 Jan 2007 00:42:47 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:44645 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965344AbXAYFmq (ORCPT ); Thu, 25 Jan 2007 00:42:46 -0500 Date: Thu, 25 Jan 2007 05:42:42 +0000 From: Christoph Hellwig To: S?bastien Dugu? Cc: Andrew Morton , linux-kernel , linux-aio , Bharata B Rao , Christoph Hellwig , Suparna Bhattacharya , Ulrich Drepper , Zach Brown , Jean Pierre Dion , Badari Pulavarty Subject: Re: [PATCH -mm 4/5][AIO] - AIO completion signal notification Message-ID: <20070125054242.GA8799@infradead.org> Mail-Followup-To: Christoph Hellwig , S?bastien Dugu? , Andrew Morton , linux-kernel , linux-aio , Bharata B Rao , Suparna Bhattacharya , Ulrich Drepper , Zach Brown , Jean Pierre Dion , Badari Pulavarty References: <20070117104601.36b2ab18@frecb000686> <20070117105018.7213ed7c@frecb000686> <20070123213513.2454b24d.akpm@osdl.org> <20070124121130.0dfc8573@frecb000686> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070124121130.0dfc8573@frecb000686> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 19 On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote: > > > + if (unlikely(!notify->sigq)) > > > + return -EAGAIN; > > > > Did this just leak a ref on the task_struct? > > > > No, the ref is released in really_put_req() when we dispose of > the iocb. And the code really needs a comment explaining this. I tripped over this before, and I think it's even already the second time Andrew stumbled over it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/