Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 15 Dec 2021 08:27:53 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Arseny Demidov <a.demidov@yadro.com>
Cc:     Arseny Demidov <arsdemal@gmail.com>,
        Jean Delvare <jdelvare@suse.com>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo
Message-ID: <20211215162753.GB2906031@roeck-us.net>
References: <20211215113023.2945-1-a.demidov@yadro.com>
 <0baa6133-5903-ffd8-69a0-99fb9f69665d@roeck-us.net>
 <06d7c6ee-2db5-f250-50f7-9a47e33a35b5@roeck-us.net>
 <c1d036c0cfa14fbb9c289f792780f003@yadro.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c1d036c0cfa14fbb9c289f792780f003@yadro.com>
Precedence: bulk

On Wed, Dec 15, 2021 at 12:36:32PM +0000, Arseny Demidov wrote:
> Yes, I have access to the datasheet and caught an error on simulation IP-block.

> The datasheet says that register "Expressed in units of IP clk cycles."
> Typical power-up delays for Temperature Sensor are 256 cycles i. e. 0x100

Please add that information to the commit description. Also,
please copy Rahul Tanwar <rahul.tanwar@linux.intel.com> and
Andy Shevchenko <andriy.shevchenko@intel.com> on your patch.

Thanks,
Guenter

> 
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Wednesday, December 15, 2021 3:31 PM
> To: Arseny Demidov <arsdemal@gmail.com>
> Cc: Arseny Demidov <a.demidov@yadro.com>; Jean Delvare <jdelvare@suse.com>; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] hwmon : (mr75203) fix macro typo
> 
> On 12/15/21 3:59 AM, Guenter Roeck wrote:
> > On 12/15/21 3:30 AM, Arseny Demidov wrote:
> >> In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256, 
> >> the correct value should be 0x100
> >>
> > 
> > How do you know that ? Do you have access to the datasheet, or is it 
> > just an assumption based on the name of the define ?
> > 
> 
> Also, how do you know that the value is wrong, not the name of the define ?
> 
> Guenter
> 
> > Guenter
> > 
> >> Signed-off-by: Arseny Demidov <a.demidov@yadro.com>
> >> ---
> >> ? drivers/hwmon/mr75203.c | 2 +-
> >> ? 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c index 
> >> 868243dba1ee..1ba1e3145969 100644
> >> --- a/drivers/hwmon/mr75203.c
> >> +++ b/drivers/hwmon/mr75203.c
> >> @@ -93,7 +93,7 @@
> >> ? #define VM_CH_REQ??? BIT(21)
> >> ? #define IP_TMR??????????? 0x05
> >> -#define POWER_DELAY_CYCLE_256??? 0x80
> >> +#define POWER_DELAY_CYCLE_256??? 0x100
> >> ? #define POWER_DELAY_CYCLE_64??? 0x40
> >> ? #define PVT_POLL_DELAY_US??? 20
> >>
> > 
>