MIME-Version: 1.0
References: <20211214031553.16435-1-yajun.deng@linux.dev> <CAPhsuW5X+zewpKoJLjMMGOUeSiJ1EYqD+0i1bA8y7SFtJLkMeg@mail.gmail.com>
 <0d07e13a5454dfb03b22e5223d101a1b@linux.dev>
In-Reply-To: <0d07e13a5454dfb03b22e5223d101a1b@linux.dev>
From:   Song Liu <song@kernel.org>
Date:   Wed, 15 Dec 2021 08:52:10 -0800
Message-ID: <CAPhsuW6T_nqqfOtj_dVn9KV+iUbki2X3WU3pxfo25Ewj3i5ZjA@mail.gmail.com>
Subject: Re: [PATCH] lib/raid6: fix abnormally high latency
To:     yajun.deng@linux.dev
Cc:     stockhausen@collogia.de, open list <linux-kernel@vger.kernel.org>,
        linux-rt-users@vger.kernel.org,
        linux-raid <linux-raid@vger.kernel.org>, masahiroy@kernel.org,
        williams@redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Dec 14, 2021 at 6:14 PM <yajun.deng@linux.dev> wrote:
>
> December 15, 2021 1:27 AM, "Song Liu" <song@kernel.org> wrote:
>
> > On Mon, Dec 13, 2021 at 7:17 PM Yajun Deng <yajun.deng@linux.dev> wrote=
:
> >
> >> We found an abnormally high latency when executing modprobe raid6_pq, =
the
> >> latency is greater than 1.2s when CONFIG_PREEMPT_VOLUNTARY=3Dy, greate=
r than
> >> 67ms when CONFIG_PREEMPT=3Dy, and greater than 16ms when CONFIG_PREEMP=
T_RT=3Dy.
> >> This is caused by disable the preemption, this time is too long and
> >> unreasonable. We just need to disable migration. so used migrate_disab=
le()/
> >> migrate_enable() instead of preempt_disable()/preempt_enable(). This i=
s
> >> beneficial for CONFIG_PREEMPT=3Dy or CONFIG_PREEMPT_RT=3Dy, but no eff=
ect for
> >> CONFIG_PREEMPT_VOLUNTARY=3Dy.
> >>
> >> Fixes: fe5cbc6e06c7 ("md/raid6 algorithms: delta syndrome functions")
> >> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> >
> > We measure the speed of different RAID algorithms.If we don't disable
> > preempt, the result may be inaccurate, right? IIUC, we only disable pre=
empt
> > for 16 jiffies. Why do we see 1.2 second delay?
>
> Here are the command of my test=EF=BC=9A
> Execute "sudo cyclictest -S -p 95 -d 0 -i 1000 -D 24h -m" in one terminal=
 and "sudo modprobe raid6_pq" in the other terminal.
>
> Here are the results of my test=EF=BC=9A
> CONFIG_PREEMPT_VOLUNTARY=3Dy=EF=BC=8CCONFIG_HZ_250=3Dy
> T: 0 ( 3092) P:95 I:1000 C:   8514 Min:      1 Act:    2 Avg:    1 Max:  =
     6
> T: 1 ( 3093) P:95 I:1000 C:   8511 Min:      1 Act:    2 Avg:    1 Max:  =
    14

I am not very familiar with the RT work, so please forgive me for some
rookie questions.

From the result, I think the CONFIG_PREEMPT_VOLUNTARY=3Dy and the
CONFIG_PREEMPT=3Dy cases failed to preempt during the preempt enabled perio=
d in
raid6_choose_gen(). Is this expected?

OTOH, the 16ms latency with CONFIG_PREEMPT_RT=3Dy is more or less expected.
Is this acceptable? If not, is 1ms latency acceptable?

Thanks,
Song


[...]