Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B2B8C43217 for ; Wed, 15 Dec 2021 21:37:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbhLOVhp (ORCPT ); Wed, 15 Dec 2021 16:37:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbhLOVho (ORCPT ); Wed, 15 Dec 2021 16:37:44 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8B9C061574 for ; Wed, 15 Dec 2021 13:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=slN8KlAG/wgd1vHM4PNJ12OXam4tmufbrpTaVHTpKTo=; b=prB8s3G23vOELlqzEyhyjNWNll LKWHcCquferLZhfY06Lks/YVUdaLOZNz6g8AdrD7A3fJ9q+EMTF51I14ICP9AYjeG0P6saRF6Baqw lo0M190NFR97czMCNFq8YmvPIs2GcPRViSOQepavjqGByomZRPa6Q8WrEc6mg6JWJDg0C+Rp1Gwn+ rkCPcRV5QOmS1BGBr/s/poqY3KmvqBwT4BX3hKr2sp4avswPb91nDobJh47BGAMEZQR1XYfA4UBP4 v7lhyU4cNWUffTvRSohqvwDBlLXO/9Bu1mE5FlixwBCcj239t/EykI3KJJuH07Umrj15HbpzkQK0e v0yCMeNw==; Received: from 211.81-166-168.customer.lyse.net ([81.166.168.211]:61446 helo=[192.168.10.61]) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxby0-0008S2-S2; Wed, 15 Dec 2021 22:37:40 +0100 Message-ID: <5b1d9578-1f74-a808-c4d4-6e8c38dd57fc@tronnes.org> Date: Wed, 15 Dec 2021 22:37:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 11/60] drm/gud: Add support for the nomodeset kernel parameter To: Javier Martinez Canillas , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20211215010008.2545520-1-javierm@redhat.com> <20211215010008.2545520-12-javierm@redhat.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20211215010008.2545520-12-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 15.12.2021 01.59, skrev Javier Martinez Canillas: > According to disable Documentation/admin-guide/kernel-parameters.txt, this > parameter can be used to disable kernel modesetting. > > DRM drivers will not perform display-mode changes or accelerated rendering > and only the systewm system framebuffer will be available if it was set-up. > > But only a few DRM drivers currently check for nomodeset, make this driver > to also support the command line parameter. > > Signed-off-by: Javier Martinez Canillas > --- > I don't understand why this is applicable to USB drivers, there's no way the firmware can setup a framebuffer and continue pushing pixels over USB when Linux has been given control over the USB bus? The same argument goes for the SPI drivers in drm/tiny/ as well. Noralf. > drivers/gpu/drm/gud/gud_drv.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/gud/gud_drv.c b/drivers/gpu/drm/gud/gud_drv.c > index 3f9d4b9a1e3d..4d253d249512 100644 > --- a/drivers/gpu/drm/gud/gud_drv.c > +++ b/drivers/gpu/drm/gud/gud_drv.c > @@ -446,6 +446,9 @@ static int gud_probe(struct usb_interface *intf, const struct usb_device_id *id) > u32 *formats; > int ret, i; > > + if (drm_firmware_drivers_only()) > + return -ENODEV; > + > ret = usb_find_bulk_out_endpoint(intf->cur_altsetting, &bulk_out); > if (ret) > return ret; >