Message-ID: <e07e7bba-0c2a-c6d2-e060-964ab3592d07@redhat.com>
Date:   Thu, 16 Dec 2021 00:26:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH 00/60] drm: Make all drivers to honour the nomodeset
 parameter
Content-Language: en-US
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc:     Emma Anholt <emma@anholt.net>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Xinliang Liu <xinliang.liu@linaro.org>,
        Edmund Dea <edmund.j.dea@intel.com>,
        Paul Cercueil <paul@crapouillou.net>,
        Tomi Valkeinen <tomba@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
        Sam Ravnborg <sam@ravnborg.org>, Marek Vasut <marex@denx.de>,
        Joonyoung Shim <jy0922.shim@samsung.com>,
        Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
        Alexey Brodkin <abrodkin@synopsys.com>,
        Russell King <linux@armlinux.org.uk>,
        Deepak Rawat <drawat.floss@gmail.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
        "James (Qian) Wang" <james.qian.wang@arm.com>,
        Joel Stanley <joel@jms.id.au>,
        Russell King <linux+etnaviv@armlinux.org.uk>,
        Qiang Yu <yuq825@gmail.com>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        David Lechner <david@lechnology.com>,
        Liviu Dudau <liviu.dudau@arm.com>,
        Alison Wang <alison.wang@nxp.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,
        Kamlesh Gurudasani <kamlesh.gurudasani@gmail.com>,
        Sean Paul <sean@poorly.run>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Hyun Kwon <hyun.kwon@xilinx.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Yannick Fertre <yannick.fertre@foss.st.com>,
        Sandy Huang <hjc@rock-chips.com>,
        =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= <noralf@tronnes.org>,
        Philippe Cornu <philippe.cornu@foss.st.com>,
        Tian Tao <tiantao6@hisilicon.com>,
        Jyri Sarha <jyri.sarha@iki.fi>,
        Erico Nunes <nunes.erico@gmail.com>
References: <20211215010008.2545520-1-javierm@redhat.com>
 <58d00cac-dbf1-9704-3c0b-16fd837a5b6b@suse.de>
 <1c1aeb13-6e90-ed2b-08db-11ceaa8d0de0@redhat.com>
 <be79a619-491b-da9f-9db4-de3919e08fff@suse.de>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <be79a619-491b-da9f-9db4-de3919e08fff@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/15/21 10:10, Thomas Zimmermann wrote:

[snip]

> 
> An extra pointer sounds indeed like over-engineering. If we take ast for 
> example, I'd just do something like this:
> 
>    static ast_pci_register_driver(struct pci_driver *pci)
>    {
> 	if (drm_firmware_drivers_only() && ast_modeset == -1)
> 		return -ENODEV;
> 	if (ast_modeset == 0)
> 		return -ENODEV;
> 
> 	return pci_register_driver(pci);
>    }
> 
>    module_driver(&ast_pci_driver, ast_pci_register_driver,
> 		pci_unregister_driver)
> 
> That removes some of the boiler-plate module code without changing the 
> driver's behavior.
>

Agreed that would be a nice cleanup and could allow to for example get rid
of the following module exit function that's just a wrapper:

static void __exit ast_exit(void)
{
        pci_unregister_driver(&ast_pci_driver);
}

But I think these cleanups are out of scope for this series and could be
done as a follow-up. Since the drm_firmware_drivers_only() check would
be needed in the module init function anyways.
 
> Best regards
> Thomas
> 
Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat