MIME-Version: 1.0
References: <20211215213300.4778-1-linux@fw-web.de> <20211215213300.4778-2-linux@fw-web.de>
 <1933509.XRPO5POFnR@archbook>
In-Reply-To: <1933509.XRPO5POFnR@archbook>
From:   Peter Geis <pgwipeout@gmail.com>
Date:   Wed, 15 Dec 2021 18:52:36 -0500
Message-ID: <CAMdYzYrpYoGY0HvSUgsgOBkhfwrqt0UfQtt1MQ7tZGbzY6pUnA@mail.gmail.com>
Subject: Re: [PATCH 1/2] mfd: rk808: add reboot support to rk808 pmic
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Frank Wunderlich <frank-w@public-files.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Frank Wunderlich <linux@fw-web.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Dec 15, 2021 at 6:07 PM Nicolas Frattaroli
<frattaroli.nicolas@gmail.com> wrote:
>
> On Mittwoch, 15. Dezember 2021 22:32:59 CET Frank Wunderlich wrote:
> > From: Peter Geis <pgwipeout@gmail.com>
> >
> > This adds reboot support to the rk808 pmic. This only enables if the
> > rockchip,system-power-controller flag is set.
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> >  drivers/mfd/rk808.c       | 48 +++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/rk808.h |  2 ++
> >  2 files changed, 50 insertions(+)
> >
>
> Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
>
> Tested with a RK817, using a Quartz64 Model A with the patch applied
> on top of v5.16-rc5. Poweroff works, reboot works.
>
>

As a note, this has come up due to rk356x having unreliable psci reboot.
Until we have mainline atf sources so we can fix the problem this is
the only way to reliably reset these devices.