Subject: Re: [PATCH] PM / devfreq: sun8i: addd COMMON_CLK dependency
To:     Arnd Bergmann <arnd@kernel.org>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Samuel Holland <samuel@sholland.org>
Cc:     Arnd Bergmann <arnd@arndb.de>, Dong Aisheng <aisheng.dong@nxp.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <a56dbd34-cd89-63a7-e24c-6f45487aa129@samsung.com>
Date:   Thu, 16 Dec 2021 11:29:54 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20211215140523.481425-1-arnd@kernel.org>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20211215140534epcas1p4a39eed46b3bd0e8582837321d1f279e6@epcas1p4.samsung.com>
        <20211215140523.481425-1-arnd@kernel.org>
Precedence: bulk

On 12/15/21 11:03 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing the driver without CONFIG_COMMON_CLK causes
> a link failure:
> 
> arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_remove':
> sun8i-a33-mbus.c:(.text+0x450): undefined reference to `clk_rate_exclusive_put'
> arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x460): undefined reference to `clk_rate_exclusive_put'
> arm-linux-gnueabi-ld: drivers/devfreq/sun8i-a33-mbus.o: in function `sun8i_a33_mbus_probe':
> sun8i-a33-mbus.c:(.text+0x85c): undefined reference to `clk_rate_exclusive_get'
> arm-linux-gnueabi-ld: sun8i-a33-mbus.c:(.text+0x878): undefined reference to `clk_rate_exclusive_get'
> 
> Fixes: 8bfd4858b4bb ("PM / devfreq: Add a driver for the sun8i/sun50i MBUS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/devfreq/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index b94eb04761f6..87eb2b837e68 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -135,6 +135,7 @@ config ARM_RK3399_DMC_DEVFREQ
>  config ARM_SUN8I_A33_MBUS_DEVFREQ
>  	tristate "sun8i/sun50i MBUS DEVFREQ Driver"
>  	depends on ARCH_SUNXI || COMPILE_TEST
> +	depends on COMMON_CLK
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	help
>  	  This adds the DEVFREQ driver for the MBUS controller in some
> 


Thanks. Applied it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics