MIME-Version: 1.0
References: <20211215174821.21668-1-zajec5@gmail.com>
In-Reply-To: <20211215174821.21668-1-zajec5@gmail.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 16 Dec 2021 04:07:12 +0100
Message-ID: <CACRpkdarh1N+NwYgDR31T=eESF20AgWJd=PTyv321jTdpH8PsA@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: add one more "const" for generic function groups
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Dec 15, 2021 at 6:48 PM Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> =
wrote:

> From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>
> Generic code doesn't modify those strings and .get_function_groups
> callback has that extra "const" as well. This allows more flexibility in
> GENERIC_PINMUX_FUNCTIONS users.
>
> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>

I really like const-correctness and I'm a fan of this patch.

It seems some users need to be modified as well though,
the test robot is unhappy.

Yours,
Linus Walleij