Date:   Thu, 16 Dec 2021 12:18:36 +0900
From:   asmadeus@codewreck.org
To:     zhuxinran <zhuran@mail.ustc.edu.cn>
Cc:     ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
        kuba@kernel.org, v9fs-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio: fix spelling error
Message-ID: <YbqwDPjapugTakhZ@codewreck.org>
References: <20211216030836.81989-1-zhuran@mail.ustc.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20211216030836.81989-1-zhuran@mail.ustc.edu.cn>
Precedence: bulk


Thanks for the patch.

A few comments below:
zhuxinran wrote on Thu, Dec 16, 2021 at 11:08:36AM +0800:
> Subject: virtio: fix spelling error

"virtio" is much more than this.
Have a look at previous commit messages for this file, something like
'9p/trans_virtio' would make a better component name.

(`git log net/9p/trans_virtio.c` to get git history for a single file)

> start my first kernel patch commit

This is not particularly useful for someone reading the git log, I'd
just remove this line.


I can do both changes on my end, but since you're learning it can also
be a good time to also see how to send a v2 (setting subject as [PATCH
v2], sending patch with in-reply-to)

I don't really mind either way, please let me know if you won't resend.

-- 
Dominique