Message-ID: <42b7c12f-659b-409a-f4e3-c7a0560b3ce6@infradead.org>
Date:   Wed, 15 Dec 2021 20:08:04 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH -next] HID: intel-ish-hid: ishtp-fw-loader: Fix a
 kernel-doc formatting issue
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>,
        srinivas.pandruvada@linux.intel.com
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20211216040146.89075-1-yang.lee@linux.alibaba.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20211216040146.89075-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 12/15/21 20:01, Yang Li wrote:
> This function had kernel-doc that not used a hash to separate

                               that did not use a dash or hyphen to separate

Patch looks good. Thanks.

> the function name from the one line description.
> 
> The warning was found by running scripts/kernel-doc, which is
> caused by using 'make W=1'.
> 
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c:271: warning: This comment
> starts with '/**', but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> index 0e1183e96147..e24988586710 100644
> --- a/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> +++ b/drivers/hid/intel-ish-hid/ishtp-fw-loader.c
> @@ -268,7 +268,8 @@ static int get_firmware_variant(struct ishtp_cl_data *client_data,
>  }
>  
>  /**
> - * loader_cl_send()	Send message from host to firmware
> + * loader_cl_send() - Send message from host to firmware
> + *
>   * @client_data:	Client data instance
>   * @out_msg:		Message buffer to be sent to firmware
>   * @out_size:		Size of out going message
> 

-- 
~Randy