Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 12.22.5.235 as permitted sender) receiver=protection.outlook.com;
 client-ip=12.22.5.235; helo=mail.nvidia.com;
From:   Alistair Popple <apopple@nvidia.com>
To:     Peter Xu <peterx@redhat.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Hugh Dickins <hughd@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Jerome Glisse <jglisse@redhat.com>,
        Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v6 03/23] mm: Check against orig_pte for finish_fault()
Date:   Thu, 16 Dec 2021 18:45:07 +1100
Message-ID: <2472202.YjDCsHb11M@nvdebian>
In-Reply-To: <Ybrljg7nWppMpfMG@xz-m1.local>
References: <20211115075522.73795-1-peterx@redhat.com> <1760244.MLhrlNdmRJ@nvdebian> <Ybrljg7nWppMpfMG@xz-m1.local>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 07:45:13.8152
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 56dd2b38-0e69-4d9a-f1d1-08d9c067fedf
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[12.22.5.235];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT021.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2534
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, 16 December 2021 6:06:54 PM AEDT Peter Xu wrote:

[...]

> I wondered how it could have worked - I thought e.g. pte_alloc_one() will
> always return a pgtable page will all zero-filled, whose allocation should
> require __GFP_ZERO anyway.  But then I quickly noticed that pte_alloc_one() is
> per-arch too..  That explains, because per-arch can re-initialize the default
> pte values.

Yes, I have wondered the same things before as well. It's all a little bit of
fun some of this stuff.

> I thought this patch can greatly simplify things but I overlooked the
> pte_none() check you mentioned.  So it seems I have no good choice but add that
> flag back.
> 
> There's another alternative is we do pte_clear() on vmf->orig_pte as the new
> way to initialize it.  I believe it should work too for s390 and xtensa.
> 
> Any preference?

I prefer the later approach (initialising to pte_clear) as it seems cleaner,
and pte_none(pte_clear()) is true for every architecture afaik.

> Thanks,
> 
> > 
> > > > 
> > > > Thanks,
> > > > 
> > > > > 
> > > > > > This change prepares us to be able to call do_fault() on !none ptes.  For
> > > > > > example, we should allow that to happen for pte marker so that we can restore
> > > > > > information out of the pte markers.
> > > > > > 
> > > > > > Signed-off-by: Peter Xu <peterx@redhat.com>
> > > > > > ---
> > > > > >  mm/memory.c | 2 +-
> > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > 
> > > > > > diff --git a/mm/memory.c b/mm/memory.c
> > > > > > index 04662b010005..d5966d9e24c3 100644
> > > > > > --- a/mm/memory.c
> > > > > > +++ b/mm/memory.c
> > > > > > @@ -4052,7 +4052,7 @@ vm_fault_t finish_fault(struct vm_fault *vmf)
> > > > > >  				      vmf->address, &vmf->ptl);
> > > > > >  	ret = 0;
> > > > > >  	/* Re-check under ptl */
> > > > > > -	if (likely(pte_none(*vmf->pte)))
> > > > > > +	if (likely(pte_same(*vmf->pte, vmf->orig_pte)))
> > > > > >  		do_set_pte(vmf, page, vmf->address);
> > > > > >  	else
> > > > > >  		ret = VM_FAULT_NOPAGE;
> > > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> 
>