Date:   Thu, 16 Dec 2021 08:52:16 +0100
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Joakim Zhang <qiangqing.zhang@nxp.com>
Cc:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up
Message-ID: <20211216075216.GA4190@francesco-nb.int.toradex.com>
References: <DB8PR04MB679570A356B655A5D6BFE818E6769@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <YbnDc/snmb1WYVCt@shell.armlinux.org.uk>
 <Ybm3NDeq96TSjh+k@lunn.ch>
 <20211215110139.GA64001@francesco-nb.int.toradex.com>
 <DB8PR04MB67951CB5217193E4CBF73B26E6779@DB8PR04MB6795.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DB8PR04MB67951CB5217193E4CBF73B26E6779@DB8PR04MB6795.eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OVG5c01/tAI8TqE6zBcaJzLep8i/F+d2qOolgonnyGex83prKTTCqGP8+qyk?=
 =?us-ascii?Q?NQ5lIn+vzaCg2ajc/xbgVTqWZWnecHdz4PGVSpwkrXYCmEaaIOM+EUxos9NG?=
 =?us-ascii?Q?NRkZNl32X9kbBYPzrd5KjmUUJnS0X5K0t9wEtA9kjqkOufCqpvArM3q+vxY1?=
 =?us-ascii?Q?3xPdNLqq5NrAdnC4GWUoZX38isL2XxizyJm+2nnWJKhKRt64zC9pt8TL+bbU?=
 =?us-ascii?Q?9FEBLT7C0hOCmQmmjesGNapLiogv8VW3dXx2JVFF3Gx98qNyGZgpo/VusU0P?=
 =?us-ascii?Q?NEFAsr1po+s1DJU2OALwXgqKSz48KzlcvdLgQCR6S+7us3yj5Lv/LkJdunTG?=
 =?us-ascii?Q?OfZx2Scv2fMoZymd4kwbWiuyMuQdsiqCEw8mXgoAhrk1pCKCk21YyIAY6s+b?=
 =?us-ascii?Q?yj3nmaKuvhVmPaize1QGVuoXGIootkA/T/d9LR85fHZckajpF1HE2ThbM0+T?=
 =?us-ascii?Q?4ldXDJc48glAa3K4/46M1Y4v0O7OgC3aYcFAXvnR1OOXQdCdb1LRn6KnVxx+?=
 =?us-ascii?Q?iFeMs+IjYxhb4LeSB0YtcuTDvFWfR7bJdryaG+18K9iqCUtlfnYv+ogrQtA3?=
 =?us-ascii?Q?qnOIJn7yxg5akCZJ2iD3Nps67b4r2z4le8bdfaF4B3NSVC2wqWF8jrbLC4f+?=
 =?us-ascii?Q?BdVau3f6Y+xnEKH16ge51X3Wo3O2X9BNPICkUlqcMxsOjoBM0X0Bvx5iam7s?=
 =?us-ascii?Q?vkOdd1jyqcjh/IWzCpbsCvHQPGEfiBEhraPD3wc+mefHvo/BJaDWlJ0Ywhwk?=
 =?us-ascii?Q?dOBSh+13jw6Kg+EG9RJFWhaLqmDClB4K2cJLrIayK+2Xb014ZV7p5hRB3sUm?=
 =?us-ascii?Q?lUwHPZJaz9z1iJsnwWfwVzNEHPn4mfT+Yx3SeDcRek0uv9Agc0rIBsevwK2S?=
 =?us-ascii?Q?XuPQ2oiEN3PpIxsahueaU7HxaTrMai9agf3boKfqNrR9DShlWYumtnVYMaSt?=
 =?us-ascii?Q?kqa4grxcTDSp0GcWXdrHiWvdrvBlfT7HAaY5eNJr5zqRgj3Wa0hvwFXwl3mg?=
 =?us-ascii?Q?48ILZ4ld1hzd9gwD5R6wUFIDs3Pez6gUswvS+w8cP+gK5ZzFyhAKoD2onCGh?=
 =?us-ascii?Q?SzJTS7OUSV94c/d1UUpk6Ai2/oXP3LHihgz0DbxDXo4stBaOZK8lYoTehx5Z?=
 =?us-ascii?Q?Pa3SAssPsB0XVl/FKG4syNkNBuaT13noLB58gFmPrynS32iJqcI86g4rFekP?=
 =?us-ascii?Q?/L+Qr1Gd1oFNhBvuX1TTmFZe/jQJzTlI9uvEuhxb6kfBaa3nzc1ll4YWsYY5?=
 =?us-ascii?Q?7bssHEq3kGf9QO9nJTtH358D0e0jk99Yag9QQ6UYao2GkZiOy+F5MGao7R7T?=
 =?us-ascii?Q?L5FXELxDVxcU2wfVLHcl/NIBRUpkm5VnSBjqmUKo+K0FTbnkGI5TexVVFybr?=
 =?us-ascii?Q?t1DShKJRNRu7hMtHqHM7xWfZrtHFAJrL6Aq0Pb4h0YD/JMJyLpr6NAuTtjM9?=
 =?us-ascii?Q?HiumIlEMex9TBx1sX8iiomei17dgJf9JWEOLrYbbSwm49X0y76HLeKe5DXBU?=
 =?us-ascii?Q?qAxTpuRcyDueNPdIMUt8m8FXkVoX46Goww/J0na5M2t/0l4jI/IQHtpQQf66?=
 =?us-ascii?Q?ZJtxfMNkVBuJaGHLhY8A2k+VONo0QkoU7HaQNADXIWcdzbJidC2WSfL8/DE7?=
 =?us-ascii?Q?gDV9iWKB/Se0tFy1BVfHPYUYjMt5ZSNzzYur1pSBGmqiJGNbyG8pDy1ldD5s?=
 =?us-ascii?Q?lwOum4o+or1oWax1ORze41/0U9M=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1832f4ae-cd9e-4f7b-70ea-08d9c068fae3
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 07:52:16.8733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lTSphw/o9jq4DDfNssUqUtCcBFqqQKSSV+mngp4XA0PhLOtf9wnEQVh1EVULzdSvNko4feS/eOx+wYFFwk8liMXHkibMaaeFKXN4MHjy/j4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0379
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 16, 2021 at 04:52:39AM +0000, Joakim Zhang wrote:
> As I can see, when system suspended, PHY is totally powered down,
> since you disable the regulator. At this situation, if you
> assert reset signal, you mean it will increase the power
> consumption? PHY is totally powered down, why assert reset
> signal still affect PHY? 
In general there are *other* use cases in which the PHY is powered in
suspend. We should not create a regression there.

Francesco