Date:   Thu, 16 Dec 2021 10:52:33 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Chanwoo Choi <cw00.choi@samsung.com>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Sebastian Reichel <sre@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] extcon: fix extcon_get_extcon_dev() error handling
Message-ID: <20211216075233.GD1978@kadam>
References: <CGME20211123084357epcas1p14833147710153f9606f14941ac8b0d96@epcas1p1.samsung.com>
 <20211123083925.GA3277@kili>
 <562b12ff-e395-c818-787e-7fd6ee6d53fb@samsung.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <562b12ff-e395-c818-787e-7fd6ee6d53fb@samsung.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9ttgxmHsfFJiPhG+NeW3SdBo4Gb6O0pwZZrDJ0wp9q7zZ7z3QOvWDrT0UJM4?=
 =?us-ascii?Q?NK+cPBRdPKFuC1OO8ISfsADrD31YnbKJd81Vr4JzpZXeUt5YNFa/u4Ecf5N9?=
 =?us-ascii?Q?MRQcSzUq9rIoblsAfnoOF6R3aN75pinDWsVVnHVOahk6rXAnM0T0rWS9agaZ?=
 =?us-ascii?Q?phq1/arfGRT/SHTTbj7pi4NyR6+jLezPfrYoiBAziEehlXcpzzdmp+UBiIQr?=
 =?us-ascii?Q?Ru0zavjeZ0NrPPXBhrO6iy/qApzMitrsmHLFD8U3LqnmTS6FvB6V98gUnCUz?=
 =?us-ascii?Q?XwQqbn84HFYtHmx4h+H4RxqLy+B1yX0Py9B/0PEePOyNT/XNn8RCu9WnYpmt?=
 =?us-ascii?Q?fhi1cK6sjQGw6p6SGvOIkQOJQImwV23XxDahy15+MsDrFhTUBouPEoyhk/7n?=
 =?us-ascii?Q?AQt+sKfiBhC4toT9L2Gx6mN4q7FZlDU/bursE4wUb0Zxcgi9vMWFzQbtemFC?=
 =?us-ascii?Q?7ckHvkwjycfaIuyS9BY8GRFRTL8Le5Q7402B7gl9dOROZaumQlLRNJR9lQ7g?=
 =?us-ascii?Q?0QfRdVOgdvk13J6gCi44qL9XSnOdMLS06IYZN4+qDFKvyG51/88gvpqhHy92?=
 =?us-ascii?Q?VZou6L7sv+mF8Z094OH69kHiw//TlItd/YCAR4DlYblhh2KXhCw4no3mUkLl?=
 =?us-ascii?Q?DLh0WouAVGKxf68mfmpC6htiboXx1SIaI/VqRpaDifHW1I/qw8FogJcdQX5i?=
 =?us-ascii?Q?LM85svN5ZKzFz9GJWJaCyHliAvTZxhoPL/i/DowFAdF47z4C3BmJuIXITOkH?=
 =?us-ascii?Q?FHZS8xAKatol7oFb2AsBrPPCOK9EULByIticfGgwIQiVKCQ0pJEJGE7uMxdg?=
 =?us-ascii?Q?4JRQxlv1Vwn8yrDVZt5itdTIxqMhDQo1ZDGGowB8LBGuUcqWK/TzPE7sU/6E?=
 =?us-ascii?Q?fpot9Nc1a1OzVL0Y9qlOcoJf+5ccl6hXvN/8isUl5symK0FjEYJA0KNDohW7?=
 =?us-ascii?Q?l5xBxO0ik25mwk4lcC0gB0hPDWZZ/xHbZzqaNrM44LCGtu73/1mk8FxGay4a?=
 =?us-ascii?Q?tZEd5X/LPoB2raTpggqeNmxNpWw6hlfHKo5Ib2G/zxTvWXJVqYRI66Ssiw/n?=
 =?us-ascii?Q?X6+c0J2/IUfnfltf/Jj9v8aeNq5JkZ6btolvpCGxJvHgCx8FF5o1nPqkI0RZ?=
 =?us-ascii?Q?jiBnZ2v4JyX5mcHk6vUX4GQWaGrn8AQxf4S5vkqTIzfaEnIcmONrqDikeNmo?=
 =?us-ascii?Q?+LP7MZSAu18mHbNcM/fac11WqZOs4lv8B+HP0Up93m4gmcwOE5ttALjWm0q+?=
 =?us-ascii?Q?4WJBr3JKPKGZolsK52NgjckNl55U2iZS5jJQzBj5/qe9WrilTUn2D+85b+bC?=
 =?us-ascii?Q?5aL44O5igHqBVv6RTLRCPS8UmQR+tt2bYL6mmovqJLozIqoaYgxRmwuMd2TH?=
 =?us-ascii?Q?vFWGquujlkyftLFBh4ZHxpPKtB2dTYki1XGNyvY06wr+EB0J50IFQNmasFOY?=
 =?us-ascii?Q?PBZJQb55TvwQBtpvFk4Izom8aceuKAhRhPrM0/6f6ovFobPmAxosoYfwvO9k?=
 =?us-ascii?Q?ZTjNC683rbpfpSrmsq/9dMADnnCvsFL+43pG+eErVIjCPf097o4qfYxEfO7h?=
 =?us-ascii?Q?OPRWbut0CiWoeVkSmeZtU67z0tOm0WBvkE9D4mUqDlpdlXtbE9Jgy3+FDdTw?=
 =?us-ascii?Q?Q1dJvUt9aE79fON+9/kDiHsEjUkV3g9XQ6n7f6qAJQvX6lLR86wRTFkgqO48?=
 =?us-ascii?Q?rZ/kBZsQqAl49Ki+L94LIMvEXTQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65b2e952-b370-4baf-9b12-08d9c0691397
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 07:52:58.6165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W82Cubhhcjoc6grAA0o7RAItpIyd0lbjleM7s8GJeEjUYvECrwNpyIE1Gpgbhh0WErxmW/mYsrkP6M9P8ZpStv3xumud27uJAp79qBWJx40=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4402
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10199 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160043
X-Proofpoint-GUID: 9SyO_DsbX1q9hoV1c9QtR-RLh0C0TB0H
X-Proofpoint-ORIG-GUID: 9SyO_DsbX1q9hoV1c9QtR-RLh0C0TB0H
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 16, 2021 at 03:39:46PM +0900, Chanwoo Choi wrote:
> Hi Dan,
> 
> First of all,  sorry for late reply.
> 
> There is one issue. About this issue, I already discussed on patch[1]
> [1] https://lore.kernel.org/lkml/5BEB63C3.1020504@samsung.com/ 
> 
> extcon_get_extcon_dev() is used for anywhere except for probe step.
> But EPROBE_DEFER is only used on probe step.
> 
> So that it is not clear to return EPROBE_DEFER from extcon_get_extcon_dev()
> because extcon_get_extcon_dev() never know either call it on probe function
> or not.

Currently extcon_get_extcon_dev() is only called from probe so it's not
an issue.

It's impossible to know what future programmers will want, but I feel
like this change probably makes it easier for them.

regards,
dan carpenter