Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D069C433EF for ; Thu, 16 Dec 2021 09:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232829AbhLPJIt (ORCPT ); Thu, 16 Dec 2021 04:08:49 -0500 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:52250 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232758AbhLPJIn (ORCPT ); Thu, 16 Dec 2021 04:08:43 -0500 Received: from [77.244.183.192] (port=64410 helo=[192.168.178.41]) by hostingweb31.netsons.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mxmki-000Cvk-Ud; Thu, 16 Dec 2021 10:08:41 +0100 From: Luca Ceresoli Subject: Re: [PATCH 1/2] PCI: dra7xx: Fix link removal on probe error To: Rob Herring Cc: PCI , Dan Carpenter , linux-omap , linux-arm-kernel , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Sekhar Nori References: <20211214221450.589884-1-luca@lucaceresoli.net> Message-ID: <59a23c89-0810-eb28-acd9-7051ac34d438@lucaceresoli.net> Date: Thu, 16 Dec 2021 10:08:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca@lucaceresoli.net X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, thanks for the quick feedback! On 14/12/21 23:42, Rob Herring wrote: > On Tue, Dec 14, 2021 at 4:15 PM Luca Ceresoli wrote: >> >> If a devm_phy_get() calls fails with phy_count==N (N > 0), then N links >> have already been added by device_link_add() and won't be deleted by >> device_link_del() because the code calls 'return' and not 'goto err_link'. >> >> Fix in a very simple way by doing all the devm_phy_get() calls before all >> the device_link_add() calls. >> >> Fixes: 7a4db656a635 ("PCI: dra7xx: Create functional dependency between PCIe and PHY") >> Signed-off-by: Luca Ceresoli >> --- >> drivers/pci/controller/dwc/pci-dra7xx.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c >> index f7f1490e7beb..2ccc53869e13 100644 >> --- a/drivers/pci/controller/dwc/pci-dra7xx.c >> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c >> @@ -757,7 +757,9 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) >> phy[i] = devm_phy_get(dev, name); >> if (IS_ERR(phy[i])) >> return PTR_ERR(phy[i]); >> + } >> >> + for (i = 0; i < phy_count; i++) { >> link[i] = device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS); > > I think this should happen automatically now with fw_devlink being > enabled by default. Can you try? Do you mean removal should be done automatically? I think they are not due to the DL_FLAG_STATELESS flag. -- Luca