Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for
 usbhid device
To:     Oliver Neukum <oneukum@suse.com>, gregkh@linuxfoundation.org,
        Jiri Kosina <jikos@kernel.org>, benjamin.tissoires@redhat.com,
        gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
        mathias.nyman@linux.intel.com, stern@rowland.harvard.edu,
        gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
        mathias.nyman@linux.intel.com, stern@rowland.harvard.edu,
        rajatja@google.com, chris.chiu@canonical.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1638956391-20149-1-git-send-email-zhuyinbo@loongson.cn>
 <caf93951-4c63-d0f1-e3f4-d0d49dec6a47@suse.com>
 <d2e4a97a-b89b-eaf4-5aaf-89af22227746@loongson.cn>
 <654e90fb-2f04-1f87-f56c-792757e140a0@suse.com>
From:   zhuyinbo <zhuyinbo@loongson.cn>
Cc:     rajatja@google.com, chris.chiu@canonical.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, zhuyinbo@loongson.cn
Message-ID: <8ed3dbee-c51c-db54-37b7-182d5a75fff8@loongson.cn>
Date:   Thu, 16 Dec 2021 18:59:10 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <654e90fb-2f04-1f87-f56c-792757e140a0@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2021/12/14 下午10:21, Oliver Neukum 写道:
> 
> On 10.12.21 10:50, zhuyinbo wrote:
> Hi,
>> system ask that must it must be accped a acpi lid open event then
>> system will always into resume state for laptop, otherwise, eventhough
>> that system be wakeuped by other event then system will continue into
>> suspend.
> Lid events are necesarily for the whole system.
>>
>> and for laptop usb wakeup that as general ask bios to enable usb
>> wakeup then if need do more things to enable usb wakeup I think this
>> usb wakeup function isn't friendly and inconveient, so enable it by
>> default.
>> after add this patch, if want to use usb wakeup function it only need
>> enable bios configure it think it is appropriate.
>>
> No. If you wish your laptop to be resumed by USB events, that is one thing.
> You can alter the system settings. That must work. But it is a different
> issue
Hi Oliver,

if you only talk about wakeup source you can think that usb-wakeup 
source and acpi-lid wakeup source was different things. but if you talk 
about laptop and distinguish lid and other event and you shoud know the 
cannotation why system still continue sleep when lid closed then system 
by other event wakeup. if you need test usb-wakeup for laptop and that 
lid shouldn't be closed.
> 
> from the default.
> 
> In general any HID device must have wakeup capability to be usable for
> selective suspend. You cannot draw conclusions from that.
you still can has wakeup capability, but it should be keep enabled by 
default. because the hid device should be convenient for human, if you 
don't think so and I think HID definition is ridiculous.

In addition, I had said that laptop usb wakeup was disabled in system 
bios by default and if user want enable usb wakeup that was only by 
configure bios and doesn't need enable wakeup node if my patch was applied
> 
>      Regards
>          Oliver
>