Date:   Thu, 16 Dec 2021 12:24:33 +0100
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up
Message-ID: <20211216112433.GB4190@francesco-nb.int.toradex.com>
References: <DB8PR04MB679570A356B655A5D6BFE818E6769@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <YbnDc/snmb1WYVCt@shell.armlinux.org.uk>
 <Ybm3NDeq96TSjh+k@lunn.ch>
 <20211215110139.GA64001@francesco-nb.int.toradex.com>
 <DB8PR04MB67951CB5217193E4CBF73B26E6779@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <20211216075216.GA4190@francesco-nb.int.toradex.com>
 <YbsT2G5oMoe4baCJ@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YbsT2G5oMoe4baCJ@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jFqFKTXGZrva/nBw5gSbwY/A+4i55qbq5D31hIY+wQ7SfDtaKT1uo3Rtigea?=
 =?us-ascii?Q?fbUa/rH6flkW8AzHFbm24spufGVMoLp+iv8swbD38Ynv5Yb4ip+mE0QYHo+9?=
 =?us-ascii?Q?QzF8xBMrSXjt6/HjFDlAO1qKLnQaN8vAyVf1o6hvRIAskLpzWkDl47YGj6FF?=
 =?us-ascii?Q?1UiDwUzcu3SAZGxRCv6H8U6HuA7XkyWaySV737CsybSm9jccBcNKU8DnvcDC?=
 =?us-ascii?Q?2wUIzzZyHmYuao3Q/3hkycXCTO5NxcUfY2Vd/BK5NiU/zBvBYLdL6e5vNobJ?=
 =?us-ascii?Q?88RLGRk9/RTjRFp+GN2tcpovzEIUwimt0jX/JrK76gOgk66W7TDMquIAiPRu?=
 =?us-ascii?Q?2nuT30mAvN26T8hiA0Ecpy/qa0e6SOLYFIs4VcoPVY9mQqaEu0Gxjx7h3Rf+?=
 =?us-ascii?Q?Cw+YBPOTD5agh/j+WLaIPEV+9g3RPVjC9YxTQGfKtN5botO9Cf7UQNTbyqQ9?=
 =?us-ascii?Q?yojC9EMHzGTl7VTTSHlUNMAEAawLtTL40Ck+r+6U0N4xAq6yX40j2+nW6HbD?=
 =?us-ascii?Q?CcaW8qaqOZXoBcLd7rItly7bxfWcKgB1sNu2jk529fle0wOhHf5EOGnjyqzX?=
 =?us-ascii?Q?MoUka3YxuaJt3qjnsVHT068ZYY7rUbTVM0tOs7wPN2bCm3FptLt4R/G+tm0G?=
 =?us-ascii?Q?47/rwJL3wYrv8lPNLomPd/t8Q8MVJ563Ho2BBtavNjP+VFNAsfqi69s+2y2y?=
 =?us-ascii?Q?LSOng+BmlkmFDsdjTU0KXoULaXsGJbmla9zyNZGz1wJjb+cSe6ZGm/PCSjQK?=
 =?us-ascii?Q?A2wYOnKeYfoSCuTu4GQ3Fek1H9uZFPAE0jkQz/dvGvB5VDcQoQFhlGu5lPwX?=
 =?us-ascii?Q?7pSozEOdZ3bsWbIDUxIGoALxJb8j1TuIFivNyfd73G1t++9K8ZyD4CrprU2N?=
 =?us-ascii?Q?9oKHF0pXCCoTkXA+gLYoHCyQFMGDsF3rAE2yWDTf/BnrOUJq/EjHXV85drBT?=
 =?us-ascii?Q?1N2AnFWVHummuk1P+4HxUMci5PK1MGUzY3N+/je8vq31BjwLMcRWFQFDFxxQ?=
 =?us-ascii?Q?HYByqpoYSNwotUjG+ASSLe79hQKLcNQ/sR+Ople1XHMwtoBr7QenZztEl4c3?=
 =?us-ascii?Q?kgEEccQM1z9YMDlRI2Ief9YND0WQO1GIaXdMwGmeat/yqP2zZER9HekBrN+F?=
 =?us-ascii?Q?EZ9/pLDV/dBVQ7B8ZGUTGmnYxsiaqbKam2pKsmlnAd0gras9Il5+VKonXI7b?=
 =?us-ascii?Q?5zq1hPxyn31go+Do3JRuVqJAnUtKEqYWcOqV8wI5XBvy21JGn8HZYR1kBWNQ?=
 =?us-ascii?Q?nhe6w3TCntWVrtDeUZrR8NNFs+IlqH8FTqHGbnlCha6cfcGjh1iLTXMeBu4v?=
 =?us-ascii?Q?gaTBO0JR1o18izk7z1tcX1oopTpAtW63nnOTw1rIgwHVQGLurxpEEx8Hzq64?=
 =?us-ascii?Q?StEAiKTLWkU/7LADPcIQ6K9w74z/Vb7quGgDcDPtcsNedSk5MOIeYmWd6/J/?=
 =?us-ascii?Q?YK83MecZKOSg3r8UdGIx8Qr00nu9ga4c1Za1lySUa3vIZcPsvoe6oHvHbho3?=
 =?us-ascii?Q?Mti6RTjDtWEvfLUtvZmXf/39V8oCK38ShbrpuWUcivDO76EKBH7JS634DCfm?=
 =?us-ascii?Q?VkLwhaqogEeQ8HtqQc4+9CMGkCIDuc6vc/5Boez808iJtO/K15D4GnbL7VrD?=
 =?us-ascii?Q?Ye023buZZIYXzK0v+tm1l0a2e7PUdoJMalqoNOaVqDKbyXWWt5q+m8Z4WkM1?=
 =?us-ascii?Q?55Y4iA=3D=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce3530c9-b7a6-49c9-f0cd-08d9c086a2c9
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 11:24:33.9616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ssmUqZnfosyRCG9ftKpNbdoscszTAsNfh6xxeOXXeosbvccGTuw530dcnZDIhRxx32oT/GMjArsFbp2jaNUJdxtKSRNGgGkqkF/qheGokiA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0250
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 16, 2021 at 11:24:24AM +0100, Andrew Lunn wrote:
> I think you need to move the regulator into phylib, so the PHY driver
> can do the right thing. It is really the only entity which knows what
> is the correct thing to do.
Do you believe that the right place is the phylib and not the phy driver?
Is this generic enough?

Francesco