Date:   Thu, 16 Dec 2021 12:31:04 +0100
From:   Francesco Dolcini <francesco.dolcini@toradex.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        "Russell King (Oracle)" <linux@armlinux.org.uk>,
        Joakim Zhang <qiangqing.zhang@nxp.com>,
        Philippe Schenker <philippe.schenker@toradex.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: fec: reset phy on resume after power-up
Message-ID: <20211216113104.GC4190@francesco-nb.int.toradex.com>
References: <DB8PR04MB679570A356B655A5D6BFE818E6769@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <YbnDc/snmb1WYVCt@shell.armlinux.org.uk>
 <Ybm3NDeq96TSjh+k@lunn.ch>
 <20211215110139.GA64001@francesco-nb.int.toradex.com>
 <DB8PR04MB67951CB5217193E4CBF73B26E6779@DB8PR04MB6795.eurprd04.prod.outlook.com>
 <20211216075216.GA4190@francesco-nb.int.toradex.com>
 <YbsT2G5oMoe4baCJ@lunn.ch>
 <20211216112433.GB4190@francesco-nb.int.toradex.com>
 <Ybsi00/CAd7oVl17@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ybsi00/CAd7oVl17@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jq5G2oCWo8vrh8dVuhu7GMlmPCWgdvib6P3mia7ifeDEeSBeDCwx7zdCmjnc?=
 =?us-ascii?Q?sPFBXVHimbDpKlSnsijdXBdgX/NMcQff3lnIaN1Io9df8G1TvwX4ZXU+Rvq/?=
 =?us-ascii?Q?endumYAL3AglrCaFSPxQ8WLOkIAdjE+wRb4GzdCQR0rOKsm5ZZrqoiC3t4Eg?=
 =?us-ascii?Q?U4jIzBAnQlgi3aJfIWT85edRojySEh6JsD/+1+UUN2uv/d7oW/Tl1m2yuNOs?=
 =?us-ascii?Q?vThCzUsJ/WvCiRImeQ/PKh5F/PnIEthzL1WuA7QWYUYDQJa1m0UGnGU2jLVS?=
 =?us-ascii?Q?iSQ6jtjjkTqdoPHU2wrNn+bOi47d07qcOoEp26PgGTqORXUvA2GQbmfM2sWq?=
 =?us-ascii?Q?Q5HdXKrD1lWWsBhkad2htdWoMVazLm7yNfx07JqByQ/5PtIdNz77UCsDF3Sx?=
 =?us-ascii?Q?O1PExl2L4i7U9bvcxQ0BqdeiRU3l4k+u5T4xjtiBOVPDmwQigpGWPSWRPSzA?=
 =?us-ascii?Q?3Vg8eG4uK/tYd7SQfAakCk1VNSb8Y+OF5T8Kl1bc/8tXkuWDlWhpt1MZRW1p?=
 =?us-ascii?Q?xllh/C83jPSV/1BSZN2lx0PBBLbfm/1i9HNlamaQ3zZpMsbCoPPOF4hmRp+s?=
 =?us-ascii?Q?tmXFyC88T+5XkNVYfkDRhADvWvRcGu45egmpMgp7+KzNYzp1pHmMic73SiW4?=
 =?us-ascii?Q?jGXNHpjP418LoAQR12oVPPv+DAXwiOJUaAD0hXV5HOJ8RHVFTMfd0EMQrs4P?=
 =?us-ascii?Q?djWcej+OG+HP9t7kNejtqusEd/vnoh5tc+W4XPxLkW+uy8IVDPyB/72Wz3RY?=
 =?us-ascii?Q?KaQbAn/EA3rluTW+ahsgxrFpuKTFev/lVw0duUNOMoO2I9UeHzvjec+UMRXe?=
 =?us-ascii?Q?GvvCY2gymYCJur+ONRJuihH03thEuRzSK9l8Zw62mkmdnoaxgcB2Ac2xKvBL?=
 =?us-ascii?Q?2V5qunDAjt+FOdfg6kTWUKvV+t79urjZ+Bbe6Epwmr0MksQJLZldjs8d1PN3?=
 =?us-ascii?Q?deiM7HcjIPCqGIFek5u6lUuQ33ABxem824Q/KqkyKAkpn8E8XF7rg3wUUdhG?=
 =?us-ascii?Q?RLjwdjB7mm8mvrWvidP1a0Ok/rrUK05avE4jlqO7vcjGNa84SlTwtQbIUlhI?=
 =?us-ascii?Q?lOmdHmsV8F6uAmRxw8r/Vqwdxgn3LWFmcRnFcpnDHuYyRMZAl+sjZ0q2bb9J?=
 =?us-ascii?Q?8gza5jOL/T72eW41snReNTGns8YzK35++E793kzhjbgeFvO14M7g0SdKe+LE?=
 =?us-ascii?Q?neyB9H/uJXCPf6JWolujXz87Sf811GasRAV03Uu7s4LXR5hKIIj3CYidgeE2?=
 =?us-ascii?Q?WXanEsgwkL9pPkIzcSSCTbSFFZKNdYMxFCidrJkryzuXq5+HbaA+3jlH+zX4?=
 =?us-ascii?Q?YcyTWrbSif94OQx9jikVrtzW0sFhJDx76qaZijBhhORWqu2hxY3mBL0avsdk?=
 =?us-ascii?Q?gsaHO2I1wHArPDADg2UyrrSlt3kADt0moQe9Nr1r4f107CkIa9u7BlmLmXqH?=
 =?us-ascii?Q?f8nd0hsXHthPBT4knDYhkQUIV2Oae4pVU7oapuhLYzW5bnSert0FbOyCqNKn?=
 =?us-ascii?Q?wCr8nNu7uJc80TbNvJ4R5ZGBp1KtaunpQP2YT7PqKGhDnGJMgt2FtjD3xiu1?=
 =?us-ascii?Q?wyk79zg34g+PMq3OGr+WjFit2t/fmhRrEJ13hceDDqGd/tdTAgfTJDpIhIcm?=
 =?us-ascii?Q?f4vdxksl8tgm/G0OCX9m2LbSgCNaGb8qBnmh2XM9MELi9w5pm/SN63wafUwU?=
 =?us-ascii?Q?1DHgLsYwIuIKJ0BIsC509+1m0o4=3D?=
X-OriginatorOrg: toradex.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e374c254-b4af-427d-8b6a-08d9c0878bd8
X-MS-Exchange-CrossTenant-AuthSource: ZRAP278MB0642.CHEP278.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 11:31:04.9575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d9995866-0d9b-4251-8315-093f062abab4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s8c5qTDOxknQIiugbIIIUMArkqQza27vb9fbi4cAzvskHeeN4fCYPgkf3MRXuF7wVgCDEtLVrAwfYPcMQe2ueGD89ZrXVbcIqI4YAWHHVMI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0123
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 16, 2021 at 12:28:19PM +0100, Andrew Lunn wrote:
> On Thu, Dec 16, 2021 at 12:24:33PM +0100, Francesco Dolcini wrote:
> > On Thu, Dec 16, 2021 at 11:24:24AM +0100, Andrew Lunn wrote:
> > > I think you need to move the regulator into phylib, so the PHY driver
> > > can do the right thing. It is really the only entity which knows what
> > > is the correct thing to do.
> 
> > Do you believe that the right place is the phylib and not the phy driver?
> > Is this generic enough?
> 
> It is split. phylib can do the lookup in DT, get the regulator and
> provide a helper to enable/disable it. So very similar to the reset.
Sounds good.

Can we safely assume that we do have at most one regulator for the phy?

Francesco