MIME-Version: 1.0
References: <20211215002529.382383-1-swboyd@chromium.org>
In-Reply-To: <20211215002529.382383-1-swboyd@chromium.org>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Thu, 16 Dec 2021 13:05:45 +0100
Message-ID: <CAG3jFysdAbHYXWv_87vB87Wf75Hev=bpjpNppdhcapb0_-dAfQ@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Set max register for regmap
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Rob Clark <robdclark@chromium.org>,
        Douglas Anderson <dianders@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Stephen,

Thanks for submitting this fix.

On Wed, 15 Dec 2021 at 01:25, Stephen Boyd <swboyd@chromium.org> wrote:
>
> Set the maximum register to 0xff so we can dump the registers for this
> device in debugfs.
>
> Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
> Cc: Rob Clark <robdclark@chromium.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 6154bed0af5b..83d06c16d4d7 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -188,6 +188,7 @@ static const struct regmap_config ti_sn65dsi86_regmap_config = {
>         .val_bits = 8,
>         .volatile_table = &ti_sn_bridge_volatile_table,
>         .cache_type = REGCACHE_NONE,
> +       .max_register = 0xFF,
>  };
>
>  static void ti_sn65dsi86_write_u16(struct ti_sn65dsi86 *pdata,
>
> base-commit: 136057256686de39cc3a07c2e39ef6bc43003ff6
> --
> https://chromeos.dev
>

Reviewed-by: Robert Foss <robert.foss@linaro.org>

Applied to drm-misc-next