Message-ID: <3ec805fc-07cc-6091-551a-771dffe459d0@amd.com>
Date:   Thu, 16 Dec 2021 17:54:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] ASoC: max98357a: Add mixer control to mute/unmute speaker
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, Vijendar.Mukunda@amd.com,
        Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20211208185850.1555996-1-AjitKumar.Pandey@amd.com>
 <YbETxcwa83U8WXTO@sirena.org.uk> <YbEYVq+uvIcoxqko@sirena.org.uk>
From:   Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
In-Reply-To: <YbEYVq+uvIcoxqko@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzBMQkVSNFlTdzZjREowSk9KSCtBQ0tOdWxKai94dlhpVzhrVWR4b25YeUJ0?=
 =?utf-8?B?RGpNZm1ZZ0lMazluL0Z3RlhpeVJYUWtGSlowMkp6MllxT2VGcVJwcFJoVkVt?=
 =?utf-8?B?ZWRsMW91bFlta0dGUFBVWDNLQlRlc1J5ZTk3MEVxbCswZytzVytFUmJmbWtx?=
 =?utf-8?B?SnVPVXRKZWRWVG85SExNZFR4WXMwSGpBOXFrZzIrbS9meVVDdy9lZ1BZSWtW?=
 =?utf-8?B?UCs4K2U2N2hSWG1jdkRrNitKNnNSU1d5c1g2RStaRnd1TEpWK3pmbWFwdno0?=
 =?utf-8?B?RGZzZzEwZFhoVEt4YnNZcS9xaXBMdzVINmF2dGpZaTQ3blVFYm92a1dTbnhu?=
 =?utf-8?B?Y29CZ2R1K0IvcXhXSTlRWDY0blRIVTdtYUh4dFcrdkQvekNiZGlHaVFlVm5z?=
 =?utf-8?B?eXVCZDdYS3FrQXBuMHl6eVZvVDhTZUZtM2tqYnczM1A4NmlSWjJDYk5jaGZD?=
 =?utf-8?B?TTZSUWpOMGN5Z2czb05ITFl1ZDZNRUVPMUJ1dlVOb094Si9OOW5OU3VwNGFE?=
 =?utf-8?B?OWNyb0FwaUdZaTluOVZDb29Hb0VJajNBdkQ0MThxOXhybUVLZTRkZmQraUpr?=
 =?utf-8?B?VldlUURBcEx1T0dvZjh4RTBOeUIwanY5dHdrSjZzOXNDMFROakZidzRJdjhv?=
 =?utf-8?B?VlBlelZMYXpZWlROUDNlUkdoaW1iNVVwcStlRllrcFVoU1NUbkswenA4OFRN?=
 =?utf-8?B?ODJTZW9XSk5oWjY2RlNmekY5UW9HUDBaWEVOOUhtUmFNMjAwSnJHNTBkN0Rk?=
 =?utf-8?B?SkdJelVpdGdSZ2xmeWhUZ1ZWS3ZIa3NsT0NkcTlMNFpNL1ZVMmtzWUx2Njdq?=
 =?utf-8?B?L1ZZSjRVZXVZZGdrN0R2ajVlbVFmdmZKbU1IaHZ6ekt4U1BYTVpicHVoSlRu?=
 =?utf-8?B?MXVKVVFpbHdhWW1wYSsvS0lscEtaQk8xaHZaZSs0ejVDL0NEVGZVaWlnVVdl?=
 =?utf-8?B?b3FFSXMraURIM3RVbzhFVnFxMXNVanZ1R0tBT04zclRJU0xyZHhWaGZkWG5V?=
 =?utf-8?B?cGxZT29NcEFlakM1YmEyVDY4TEhlc0FqTW1QWGc2L0dhWjVwRlNZcTZ0SThL?=
 =?utf-8?B?VlNJYzJkeW44WEdhUU5vaHZWMGdtQTZheGgvSXR0VGxLMzVxbi9vYUd5Z2JD?=
 =?utf-8?B?MW05b1hLMkhxRjZQRWM4cnlndHYzRnhjZWtncHhlZi9vQjRSL255aTVXdEZh?=
 =?utf-8?B?bnV6YmI2SFVVbjFWNWh5cVloU2xwdlVLb1cxU0FuaS90VUdEaWNSOGVsM3V2?=
 =?utf-8?B?STJjZDdsQm1GQ3ExdlNtdFZ3Nk8rNXVCdkpXa3ZzVWJBdzE4bVpJNzNPK2Nt?=
 =?utf-8?B?ZTloUkNiQnNZc1hXc0NlRXh6VFE0Y0hHem8rNUxTZE9HTTVUMzNuRmtralBF?=
 =?utf-8?B?Y3I3ZjJISEdjWmtRdGhscjh2dDB2cklIYStVajNvU3lXaUdybFRQSkU5U28z?=
 =?utf-8?B?YVhqQnZGWStMdWNpMXFpWXVkK2VTV3FlbStQOHUya3grUFdoVG5KSzJ0VEdO?=
 =?utf-8?B?VVlZem5HWkpYRnlFRGRVTVZlQlRaMm9JVGlNNGVoMmpRcnpaQlkzVEd3ek12?=
 =?utf-8?B?ZXk4MmhBcTdRM1FqOTdUOHc5Qk1YRWp5d0pXMEMrZU9WaDIwaEtCUkdmRlFz?=
 =?utf-8?B?bzhmSmdWZE5XOXVvakVMYktBRE9kUXhwV2srWDZML3BzVjZzb0RZSTU0dE1t?=
 =?utf-8?B?SDlXZUt1OUl2T2drN1FKZEMzdTRDZGhLckdVWFhkSndhcjlMdkM5Vmh5Q2Yy?=
 =?utf-8?B?cUVNdTNPay90N0pteFdka0tzcUVpc3lIbTNqZ09lUi9PeUdJTjBxL3lvUkpp?=
 =?utf-8?B?OGlnNkpqUS95bXhUYXFjNTlINEJIbzljeTFOK21DYXJ0OVFaQTV3U3NJK3ho?=
 =?utf-8?B?R2ZaYXpuM1N2Q216bTE5R3hiOTd3d3JEdG85TTJYZjY2M1hwR2xJZW5SM2lt?=
 =?utf-8?B?TTFLU1RxL2NWMG5kZnJFVE8xZks0Q3FnMEhsZi9jVmVFb1JzNTRPbUhqYkpt?=
 =?utf-8?B?RTdvTy9IRExsU3VxbEI2U01RbEdmalRwNGwxVzJvelR2aGNkb2l0WTgzNWZo?=
 =?utf-8?B?ZTV6Y0Ntb0pOOGIrdXJEUUgwcTZsMGRUaVcwSXp0d2JkOXhTNFdoMStxemR3?=
 =?utf-8?B?L1BYNFplaS9rN0Zlc3NTTDcwallVa0FZdkVCQkhwSEUzMm5welJRUCtaN2Nl?=
 =?utf-8?Q?RUZzRfBdA9obF92DVG359D8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eb6ddd03-2078-48fb-4aab-08d9c08f148e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3627.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 12:25:01.0959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s0mzxR/mXJtxNV6Dgs6okkBbKCfwQoMA/8dlkTYVjMC0oSnELIQSMERpQ/evr0XsI+9rW04hpWqYjnDRSflKCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2681
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/9/2021 2:10 AM, Mark Brown wrote:
> Actually now I look again the only control interface this driver has is
> GPIOs but it does expose a digital interface with constraints as input
> so doesn't fit within simple-amplifier.  However this is just powering
> off the amplifier to achieve mute rather than a separate mute control so
> it'd probably be better to use a SND_SOC_DAPM_PIN_SWITCH() for the
> Speaker widget to do this, this would also end up addressing Jaroslav's
> thing with the naming as a side effect.  Sorry about the confusion there.

Thanks for suggestion. We tried using SND_SOC_DAPM_PIN_SWITCH() for the 
speaker widget and it invoke dapm_event callback based on switch i.e 
max98357a_sdmode_event() but codec driver isn't enabling/disabling gpios 
in such event callback instead they are doing that in dai_ops trigger 
callback. In our platform single I2S controller instance (cpu-dai) is 
connected to two different endpoints with a single PCM device, hence we 
want to switch or enable/disable output based on Machine driver controls 
only.

Initially we thought to configure gpio within sdmode_event callback but
there was some pop noise issue reported in one platform with that change
hence reverted. Check 
https://patchwork.kernel.org/project/alsa-devel/patch/20200721114232.2812254-1-tzungbi@google.com/#23502085
So we thought of exposing a mixer control to enable/disable amp from UCM
in our platform without breaking existing functionality. Please let us
know any other alternative way if possible.