Date:   Thu, 16 Dec 2021 12:31:36 +0000
From:   Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To:     cgel.zte@gmail.com
Cc:     lars@metafoo.de, chi.minghao@zte.com.cn, nuno.sa@analog.com,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH iio-next] drivers/iio: remove redundant ret variable
Message-ID: <20211216123128.54c51264@jic23-huawei>
In-Reply-To: <20211215060710.442163-1-chi.minghao@zte.com.cn>
References: <20211215060710.442163-1-chi.minghao@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 15 Dec 2021 06:07:10 +0000
cgel.zte@gmail.com wrote:

> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Return value from ads8688_prog_write() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

applied,

Thanks,

> ---
>  drivers/iio/adc/ti-ads8688.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c
> index 79c803537dc4..2e24717d7f55 100644
> --- a/drivers/iio/adc/ti-ads8688.c
> +++ b/drivers/iio/adc/ti-ads8688.c
> @@ -281,12 +281,10 @@ static int ads8688_write_reg_range(struct iio_dev *indio_dev,
>  				   enum ads8688_range range)
>  {
>  	unsigned int tmp;
> -	int ret;
>  
>  	tmp = ADS8688_PROG_REG_RANGE_CH(chan->channel);
> -	ret = ads8688_prog_write(indio_dev, tmp, range);
>  
> -	return ret;
> +	return ads8688_prog_write(indio_dev, tmp, range);
>  }
>  
>  static int ads8688_write_raw(struct iio_dev *indio_dev,