Subject: Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for
 usbhid device
To:     zhuyinbo <zhuyinbo@loongson.cn>, Oliver Neukum <oneukum@suse.com>,
        gregkh@linuxfoundation.org, Jiri Kosina <jikos@kernel.org>,
        benjamin.tissoires@redhat.com, Thinh.Nguyen@synopsys.com,
        mathias.nyman@linux.intel.com, stern@rowland.harvard.edu,
        rajatja@google.com, chris.chiu@canonical.com,
        linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1638956391-20149-1-git-send-email-zhuyinbo@loongson.cn>
 <caf93951-4c63-d0f1-e3f4-d0d49dec6a47@suse.com>
 <d2e4a97a-b89b-eaf4-5aaf-89af22227746@loongson.cn>
 <654e90fb-2f04-1f87-f56c-792757e140a0@suse.com>
 <8ed3dbee-c51c-db54-37b7-182d5a75fff8@loongson.cn>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <78229065-61e6-3d61-8cf3-3c24c0f96ae2@suse.com>
Date:   Thu, 16 Dec 2021 13:42:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <8ed3dbee-c51c-db54-37b7-182d5a75fff8@loongson.cn>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7sKYyTcqX6mnTzCMHBqXFZluNRmy9qz0dJ6+j7YwnjMDMMlBs8NfYzxqyC4u?=
 =?us-ascii?Q?hTAVE69DH9aWw/bfyxJQSnQBCFN+/ZL6BGzcddQ4mWhwDGNOEaod+Ir46ZiQ?=
 =?us-ascii?Q?endZ6x4NiBFOK5bwBhSP7CCTVzm5Wt7B//mcDhsq8kEdLABoMutadKB2ghKP?=
 =?us-ascii?Q?iqqY3Q8uUUoUSjkpbjNH7YxlvHVGq/XAg5XzHyiiT7h87kjnNtM6JHDLRZaw?=
 =?us-ascii?Q?5Uxor2Y28C/ndTwFA7QndPmRN334Xmxg82ZUzRmVatEvN8qr3HdpW/S4GaGN?=
 =?us-ascii?Q?mGzfEBAMxpT7MuZTnTJn2PgJbAVw7UGJtx8HS0DfEQmoCRTVEHBRv63KVHR5?=
 =?us-ascii?Q?6c/8yxcIZn1LZxLZnHs96vKTKc2ieQQHsy0LGGzwb7cWDPQI1Sf2VFRn5X3a?=
 =?us-ascii?Q?4Dax0VbTEcZxIvCvjyY/jHVkiQePpUZJZjVzPB0R85n5X4UbCwlIkwoBAijT?=
 =?us-ascii?Q?yfBqlFgNSbpa8qJrmi1sIKiWipUI+gaQ09Sh8NCgg9Rq43ZWAJA+YX476o6n?=
 =?us-ascii?Q?qqrHMNVY511R3jStQVowx2ZXkMXocBoeZ/6KDdhgbtszttLf/VnCm9viGhRY?=
 =?us-ascii?Q?Td0y9u7GsWD6Rj3xI9NiZ59zzdLFxwZzYMqpec1PHgu9fGPGFG7QEWjNS9pY?=
 =?us-ascii?Q?d004d+xOha4OyZzpQp6nb5KQmQ8+HXy16nNpqSaS6Kqow4xVwMUvSu5XPUlP?=
 =?us-ascii?Q?56xJO9Ue1UJCEYQMn4m4uZOO5IIcyGugFoeXovQ7BbD4DBlMuyLkkdXa2ifN?=
 =?us-ascii?Q?c795gFuHd+ompUALF70iSt+JG0cMZYvaND9Ljsk4oVcOtmsAhB4n5+d+01ou?=
 =?us-ascii?Q?APvtJOb95Vc8SbRhoD37bGlG/8ah7VOThncSB+NkzrjIItWdJdFWkw1WBcNw?=
 =?us-ascii?Q?J2zJUKAWmp9zwx93ylbRSxbcE3kQaH49Wr//rVbAqPyObiZmybKF8WBEAXQa?=
 =?us-ascii?Q?aWAPQotDwBTTooCu5HQrWDoF5WlKDXVZzZoDML9TP9zq09fQ27JWNGiKxSE6?=
 =?us-ascii?Q?jmgZeMWNaYjhyQEApOVKTBTV+je74OluJwx47tjAhPcbEUzTeSvDaror8Kme?=
 =?us-ascii?Q?Uo0++VSzJzHxZnIB2/UNbfjXlfvZaO3xZXvxX/OU4XVr4wmArbjHrAVfrM35?=
 =?us-ascii?Q?4qa6tFDbvMo/2DLcfkCNs5ZSRlheBQ9uB0ONLo2DWwCArWS76Ecku6CfB3jF?=
 =?us-ascii?Q?tqI3LQ2H+bo2E3JNrZqLPUtIOWs0yNYcEC64c3jOM24iLFTxUrOIgLwSkEjf?=
 =?us-ascii?Q?pjE6dHkCa5YFOgS/8tYRD6BjsbArhlXsrCZa1vUpAN2/XWbPcwk7vBxTQbR0?=
 =?us-ascii?Q?YpFYj2VjYZLMR7kLOGxtr/0UApjxXJ7ZkmHniXCbFsMqovamiddAgdxssPAX?=
 =?us-ascii?Q?Klpd8z5i0gsaCTJFKiM8EcfbDHYm7Tx4Jo9DxFD4y4oga+do9Fpv1cZEj7V+?=
 =?us-ascii?Q?983csNfwXJ55sO4e+pnNI6JET8GNH7rg7nhaGXlozQLsY702+Yb2fLJrfbe5?=
 =?us-ascii?Q?M2wDFvFHvi1UanzUZzJ/FcU0LGakIOS9td4AWR2+YYO+Q5AJAJcNNaCqHuUj?=
 =?us-ascii?Q?WeDv+DNX7kTlwGKIO0MFueaT6L0Hq6F1wGEYchMEtD1JSg6jcb65Gokm57cd?=
 =?us-ascii?Q?EZFmYi9ij4vGeOJ2dXPVUOOp5+PsYx1CEnguUkyWOjaMQAkc/18vnvfqWMdp?=
 =?us-ascii?Q?QL60rxvA7BdflSqzOTYWmiTW8/Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49770cf1-27e1-47c9-da74-08d9c09179d2
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 12:42:09.7397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HrIITNo0jWHlh6Y8szOmUXU44y3kMhD97CwfvkdZhSUrX4xftbj9cyAYXca0wEDtUi8lIKcf22rDboxsoHcexw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5609
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 16.12.21 11:59, zhuyinbo wrote:
>
>
Hi,


> if you only talk about wakeup source you can think that usb-wakeup
> source and acpi-lid wakeup source was different things. but if you
> talk about laptop and distinguish lid and other event and you shoud
> know the cannotation why system still continue sleep when lid closed
> then system by other event wakeup. if you need test usb-wakeup for
> laptop and that lid shouldn't be closed.
I am sorry, I am not sure what you wish to say here. Could you rephrase it?
>> from the default.
>>
>> In general any HID device must have wakeup capability to be usable for
>> selective suspend. You cannot draw conclusions from that.
> you still can has wakeup capability, but it should be keep enabled by
> default. because the hid device should be convenient for human,

Well, no. We are talking about a kernel default. That needs to be so that i=
t
always works on all systems. Convinience is secondary.


> if you don't think so and I think HID definition is ridiculous.
It does have its weaknesses, in particular with respect to differentiating
between events for wakeups. But we cannot change it.
>
>
> In addition, I had said that laptop usb wakeup was disabled in system
> bios by default and if user want enable usb wakeup that was only by
> configure bios and doesn't need enable wakeup node if my patch was
> applied
If you deviate from the default, you deviate. That is reducing the number o=
f
changes is worth little. The default must be above everything else safe.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver