Date:   Thu, 16 Dec 2021 13:59:55 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Viresh Kumar <vireshk@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Peter De Schrijver <pdeschrijver@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        Lee Jones <lee.jones@linaro.org>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Nishanth Menon <nm@ti.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org,
        linux-mmc@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-clk@vger.kernel.org, David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers
Message-ID: <Ybs4S4WMJBhAEWWp@orome>
References: <20211130232347.950-1-digetx@gmail.com>
 <20211130232347.950-30-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ZQq/1UzGq+uUb+/w"
Content-Disposition: inline
In-Reply-To: <20211130232347.950-30-digetx@gmail.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--ZQq/1UzGq+uUb+/w
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 01, 2021 at 02:23:36AM +0300, Dmitry Osipenko wrote:
> Use resource-managed helpers to make code cleaner and more correct,
> properly releasing all resources in case of driver probe error.
>=20
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c   | 32 ++++++++++++++------------
>  drivers/soc/tegra/fuse/fuse-tegra20.c | 33 ++++++++++++++++++++++++---
>  2 files changed, 48 insertions(+), 17 deletions(-)

Ehm... this is very borderline. Adding 31 lines of code isn't exactly
making the code cleaner.

On the other hand I don't care enough to get into an argument, so I've
applied this anyway.

Thierry

--ZQq/1UzGq+uUb+/w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG7OEkACgkQ3SOs138+
s6EVgw//Q1bJ7UIWESNDxmwd9IN5+l1yqA6koyP2/T9lZI6CZwZSmWcUUSpFP/5W
FrIkEWkLWqBfpCCHSSi3DqBQRffF5XV/+VY/CgF7jkB5e8aQplyBe4NXabp8q2lu
+emE4bjR0Kx4MKewjHp6H+RPRDtatG1YmytnsHChDb/lB2lCTWawoYxjI9FuJLQI
R+x0XMaa6zKM9Df3r3cbUf5vnk+aXUqQJ+CnIRxxHJR2Y+/toDoG1xw3igwQoBSF
+PBJ9p5YrHUhgk3IeS3D7LskY995tCgIjNhT3BlZEDax/m+KlSAVvW1SxrVmDorz
/P4+MIrZc3n21VI8MbB3GYEswiOH28v56uR6fYLidA+SKOhf6GpZ5YfHJCEImdf9
FXsn159vQIuwDAbrxZAW2rXGMJ0Ob9js0+e6F6Ef4gDcvHQVAqjyCzL477yzZzAM
QWG9iGVewC5a8t+XyyUHiUegvFPM3FyM+BCybdFmADW4CBvI9Hm3wAG82YNOuY2b
9gNymg0VeNUxQGu6LmKlgjXJ6H9L/9ecVxdQ4HHEcImotUXXaRheMyig16CF7HQP
C0bqGjndmSWu2BkHYl7LHPF9gYtwYzjhTCHF0kTfLXLwCPrbCwxATChiTvITfPmz
PDsmbJI2R6IygKQgpD39dqYrW8Y4QkyU7AjivlraXC9X31tp/yw=
=b3Ro
-----END PGP SIGNATURE-----

--ZQq/1UzGq+uUb+/w--