Date:   Thu, 16 Dec 2021 14:44:56 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     David Heidelberg <david@ixit.cz>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        ~okias/devicetree@lists.sr.ht, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: sound: nvidia,tegra-audio: Convert
 multiple txt bindings to yaml
Message-ID: <YbtC2I49D0pdcyLY@orome>
References: <20211211224946.79875-1-david@ixit.cz>
 <a84213cb-272a-f1b2-338f-ed8ed0bf133d@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="VYhNuZYXPUbD/PRF"
Content-Disposition: inline
In-Reply-To: <a84213cb-272a-f1b2-338f-ed8ed0bf133d@gmail.com>
User-Agent: Mutt/2.1.3 (987dde4c) (2021-09-10)
Precedence: bulk


--VYhNuZYXPUbD/PRF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 16, 2021 at 05:52:12AM +0300, Dmitry Osipenko wrote:
> 12.12.2021 01:49, David Heidelberg =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    sound {
> > +        compatible =3D "nvidia,tegra-audio-rt5677-ryu",
> > +                     "nvidia,tegra-audio-rt5677";
> > +        nvidia,model =3D "NVIDIA Tegra Ryu";
> > +
> > +        nvidia,audio-routing =3D
> > +                "Headphone", "LOUT2",
> > +                "Headphone", "LOUT1",
> > +                "Headset Mic", "MICBIAS1",
> > +                "IN1P", "Headset Mic",
> > +                "IN1N", "Headset Mic",
> > +                "DMIC L1", "Internal Mic 1",
> > +                "DMIC R1", "Internal Mic 1",
> > +                "DMIC L2", "Internal Mic 2",
> > +                "DMIC R2", "Internal Mic 2",
> > +                "Speaker", "PDM1L",
> > +                "Speaker", "PDM1R";
> > +
> > +        nvidia,i2s-controller =3D <&tegra_i2s1>;
> > +        nvidia,audio-codec =3D <&rt5677>;
> > +
> > +        nvidia,hp-det-gpios =3D <&gpio 143 0>;
> > +        nvidia,mic-present-gpios =3D <&gpio 132 1>;
> > +        nvidia,hp-en-gpios =3D <&rt5677 1 0>;
> > +        nvidia,dmic-clk-en-gpios =3D <&rt5677 2 1>;
>=20
> I spotted that nvidia,dmic-clk-en-gpios is undocumented, but DTs and
> binding are passing the validation. We will make another patch to fix it.
>=20
> Rob, could you please tell whether this is because unevaluatedProperties
> doesn't work yet or we're missing something?

If you update dt-schema.git to the latest "main" branch you should have
most of what's needed to make unevaluatedProperties work. However, there
seems to be an issue with some $referenced schemas setting
additionalProperties to true and then that gets propogated to the schema
that included it.

Rob came up with the patch below to fix that:

--- >8 ---
diff --git a/dtschema/lib.py b/dtschema/lib.py
index 3cc5e428b0eb..a0f22aab935a 100644
--- a/dtschema/lib.py
+++ b/dtschema/lib.py
@@ -367,6 +367,9 @@ def fixup_sub_schema(schema, is_prop):
     if not isinstance(schema, dict):
         return

+    if 'additionalProperties' in schema and schema['additionalProperties']=
 =3D=3D True:
+        schema.pop('additionalProperties', None)
+
     schema.pop('description', None)
     fixup_interrupts(schema)
     if is_prop:
--- >8 ---

I'm currently running the tools based on that and it's indeed been
flagging some properties as unevaluated that weren't there before.

Thierry

--VYhNuZYXPUbD/PRF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmG7QtUACgkQ3SOs138+
s6HjCxAAuTnbsKxAgxycX85cJbBSIHKr0b51aKNXDI71KKBxLN4QSgOtVa7ZyTyh
vj1eR6Ub2iMKQqd20prcPw2G/OyDMT4Ej3+UK14zAGfOPIgPHzTuTivT2yAmdZQY
qMC1rz2YpzLxUWMbiL7d5BUWH10feHqodEhEYyR5ai4dayw5h3uTaXU3zAg6nrxv
t3us4Am42PXfUKk8v7yEBoKCr9N6p45xI3oAjlzmcTcUmJ/znM4ExIUW/vNsXUYb
vehBTrfGWLwF/Zc8FXHrqa1ZWIUVuVdhJq8gBCKURp7Aq34eXQLyBKc2yzWzTr1U
u8Bd1Ui5bUOvqG+pijUaNnELUBNu042FSlj26UZsbbATxnvj/rT60477YfE7IjJg
0nBTUGR9tCeqJT7PNdQ2qrycFnwIDSokNldvCjxGO+dYf1mTC1F7GHYp1xN92qtK
wPNPqt97gnajhx0rUIvXBuFMDRhhz8dsSPZTPK0vuoo7r6Ot0k5MaweCT1B+SoKw
tYIKnXImguOGPXKX14DAmRdMO5mVUF2L4tnWlBiTMRaN0YjEESkdtfUKfOp2Drg5
P0GU9HyOB84/yfHnd23+osuqB1kWWIZ8DTLyf+GJ3K2KSL7gZA+IUsqawHGZTdvx
96U+hM8GBu77CfrjrHoUGftBOSz+vGdNRU4/fxJxTMEHpaVRTHc=
=FRv9
-----END PGP SIGNATURE-----

--VYhNuZYXPUbD/PRF--