Date:   Thu, 16 Dec 2021 22:12:03 +0800
From:   Peter Chen <peter.chen@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: chipidea: Set the DT node on the child device
Message-ID: <20211216141203.GA6025@Peter>
References: <20211215225646.1997946-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211215225646.1997946-1-robh@kernel.org>
Precedence: bulk

On 21-12-15 16:56:46, Rob Herring wrote:
> The ChipIdea glue drivers just copy the glue resources to the "ci_hdrc"
> child device. Instead, set the child device's DT node pointer to the
> parent device's node so that platform_get_irq() can find the IRQ
> resources in the DT. This removes the need for statically populating the
> IRQ resources from the DT which has been deprecated for some time.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Peter Chen <peter.chen@kernel.org>

> ---
>  drivers/usb/chipidea/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index a56f06368d14..5359b2a2e4d2 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -864,6 +864,7 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
>  	}
>  
>  	pdev->dev.parent = dev;
> +	device_set_of_node_from_dev(&pdev->dev, dev);
>  
>  	ret = platform_device_add_resources(pdev, res, nres);
>  	if (ret)
> -- 
> 2.32.0
> 

-- 

Thanks,
Peter Chen