Date:   Thu, 16 Dec 2021 16:00:21 +0100
From:   Miko Larsson <mikoxyzzz@gmail.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
        axboe@kernel.dk, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] zram: zram_drv: replace strlcpy with strscpy
Message-ID: <20211216160021.1b9e6d87@zenorus.myxoz.lan>
In-Reply-To: <YbsRlDYT2BfgrXRX@infradead.org>
References: <20211215192128.108967-1-mikoxyzzz@gmail.com>
        <20211215192128.108967-3-mikoxyzzz@gmail.com>
        <YbsRlDYT2BfgrXRX@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 16 Dec 2021 02:14:44 -0800
Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Dec 15, 2021 at 08:21:28PM +0100, Miko Larsson wrote:
> > strlcpy shouldn't be used; strscpy should be used instead.
> 
> I think the proper API to use here would be kmemdup_nul.

Thanks for the heads-up! That only seems to apply to the assignment of
'file_name'. The usage of strscpy seems to be correct in the other two
cases, though (since they're char arrays.) I suspect I might be wrong
though, since my knowledge of C is shabby at best.