Date:   Thu, 16 Dec 2021 15:46:57 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     William Roche <william.roche@oracle.com>,
        linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v2 2/2] EDAC/amd64: Add new register offset support and
 related changes
Message-ID: <YbtfcUmWAFDWMG9w@yaz-ubuntu>
References: <20211215155309.2711917-1-yazen.ghannam@amd.com>
 <20211215155309.2711917-3-yazen.ghannam@amd.com>
 <d327bbfe-a3c0-9b26-569d-43e17dba126d@oracle.com>
 <Ybou1VTJ8oced4Ge@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ybou1VTJ8oced4Ge@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+ihLW8Zo2H99CUHGF8bXdJb7TlDxwFWB/r36WXRF72iL1yfHUQVr8VX7nnw9?=
 =?us-ascii?Q?HhbvJjZcyb2GKSerpIXlk6XbaJ3i27bT+NYyAP9kltFltybZLWiFhcpaR7IW?=
 =?us-ascii?Q?fJLV+db9AnmPKPVvm8K2az9SVwrdVJ/VGr3YnZQUCU/bVj5sjwroq3wdG5vt?=
 =?us-ascii?Q?nkzaBqwZgoqY4+LeHUKZy7Q3z/DKgtaQMaSyZnlyOrQ3rMzBeNz0P4PDzkEF?=
 =?us-ascii?Q?p8tHM2hU6ot9nCz051xfqRnpY0Q+vk1HpXLQXmZc4tzYU6Zv4kGyml1U5Grr?=
 =?us-ascii?Q?P/l/VntLoYoxF9RDyzFdMwnlXosC5JVAnJW9BMH/mV766hUA2+2TeG1kMAQH?=
 =?us-ascii?Q?LgRRTpNu1HccW5+6Guzt24pzISW8Igz/NInWnNT+As3b3Doyj/ERKAK2Myh3?=
 =?us-ascii?Q?Dce6xH529BXBOuB12EO6VA+109UiQBqHUnbokZ3JCr1HFXf0SrYlHtm5RFj3?=
 =?us-ascii?Q?Ex54Nb8mmQLn0fgPJ8PlJJLZE75UyLWL6jLo9rkJhH7wk5Wqy2LtmaDS1JyZ?=
 =?us-ascii?Q?s1OXnZdqPaBhZw/Ggt6m9VZMm2xJMsU57T8XCnyytFGpz85cks9pzXKJo3nF?=
 =?us-ascii?Q?ptcQ4fdI1MNLenqCa+/no+RY22M2gh29JkdNgnCzlDmBh6ez+D7ENNcUwsDJ?=
 =?us-ascii?Q?5QMpGMOPaML17wE5hAXI/k8aHHJRYYfNo+RGmvofBwygy9gbS7ZJDLFJduuG?=
 =?us-ascii?Q?G0Qb4japOjwU7EvH9+hx5+znqJPJY0Y1zGBhcW4wBsbsN6o11wvbhBalHpSu?=
 =?us-ascii?Q?17dbn3TYbSP+dJArSwz03J9gZCppzxXQAvlLoU9K84ei8GeNeYk3q/gTc3w+?=
 =?us-ascii?Q?+ORZ9EDw33dMppgMz/bD7WcuN0C2ZGiJXngEubf0HCw/6HG4D//sGx9KCceo?=
 =?us-ascii?Q?QJ3Ng5E/+TiyZC40MjDbRRJSEdKRkcepTy/O1LLgaDTNpez3w5R3ww1tWDJT?=
 =?us-ascii?Q?Jb8KFfNYy5aQtijh838kseRQSmPggChTqPYtsPofvXAOyJKMHVl3KIROWgU6?=
 =?us-ascii?Q?CTnBSMvXqiYPgYBiR1mCVoRm/yHP3+HvFQ0E/8oyut1/+lRewnhAtmrn2Q3K?=
 =?us-ascii?Q?EYILmVBzcSFlQExBCDigFOg24v2f+59RNIRCXEEZTUzB7K7Q5AMcPY/+tOdR?=
 =?us-ascii?Q?FA4xv+VmHU2MMqfDGu5xoWjcasx4yd3OZyXcMH4HpDR8g7K1e1tHyRoGKDn8?=
 =?us-ascii?Q?ikClNZJZyf83P6Hecp+yFknd6j1rB9nhukGlgnE+bNe28BX0WFWDOC+fmvNd?=
 =?us-ascii?Q?Rr5hq6RqBQJ0gu5CIgzFxlYxa9cesurtyCN3wpeAzR2dcK+YSJP4dlLnkQjs?=
 =?us-ascii?Q?Z3LyzI2pEIU9+L5TD2o7k45to63MyHKR1PYnt3F1LRlN36DyjNflNM52QsmQ?=
 =?us-ascii?Q?SP2fsY5zLwmjE/CbnqPrDC3b8Oe2U/JkmFAGMN21e5kaFBppJqL0dAlbF9R+?=
 =?us-ascii?Q?souo63x2Hf1fpnBbhbCU1SAU/6cib5DFv77mkJJKCl9+sJUadxKZze9mIJWE?=
 =?us-ascii?Q?fyfoF0HhLio5nIisJv70u7kGVp1QI9hcH9w4CO2dbaj67t5I/NZzcd0mZklW?=
 =?us-ascii?Q?YlmbDvRrTNbJ39hbgZ/kKwFeL+dCkNCHGJ5Dv5g1hZ13+mEty6OrW6EgIKEt?=
 =?us-ascii?Q?gH5d0q9t9qKhdnhtJVzUMW4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e347ddd-c11f-4c3e-1371-08d9c0ab4ef7
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 15:47:04.7954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vFfPfzYzSBkZoApY/mh3PQbAgrWoWkGPiYDg4VE0J1c825mNb0Cb8MHGiRZwxRIwrIF2nwSw3skp392nPosEVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3364
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 15, 2021 at 07:07:17PM +0100, Borislav Petkov wrote:
> On Wed, Dec 15, 2021 at 05:32:27PM +0100, William Roche wrote:
> > > @@ -2174,8 +2215,13 @@ static int f17_addr_mask_to_cs_size(struct amd64_pvt *pvt, u8 umc,
> > >   	 * There is one mask per DIMM, and two Chip Selects per DIMM.
> > >   	 *	CS0 and CS1 -> DIMM0
> > >   	 *	CS2 and CS3 -> DIMM1
> > > +	 *
> > > +	 *	Systems with newer register layout have one mask per Chip Select.
> > 
> > Just a question about this comment: Can it be translated into this ?
> > 
> > +	 * Except on systems with newer register layout where we have one Chip Select per DIMM.
> 
> Sure, but without the "we":
> 
> 	...
> 	* On systems with the newer register layout there is one Chip Select per DIMM.
> 	*/
>

Hi William,
Thanks for the suggestion, but it's not quite correct.

There are still two Chip Selects per DIMM module, i.e. the system can support
dual-rank (2R) DIMMs. Current AMD systems can support upto 2 DIMMs per Unified
Memory Controller (UMC). There are two "Address Mask" registers in each UMC,
and each register covers an entire DIMM (and by extension the two Chip Selects
available for each DIMM).

Future systems will still support upto 2 DIMMs per UMC. However, the register
space is updated so that there are now four "Address Mask" registers per UMC.
And each of these registers is now explicitly related to one of the four Chip
Selects available per UMC.

Does this help? I can update the code comments with these details.

Thanks,
Yazen