Date:   Thu, 16 Dec 2021 08:08:49 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
Cc:     netdev@vger.kernel.org, jhs@mojatatu.com, mickeyr@marvell.com,
        serhiy.pshyk@plvision.eu, taras.chornyi@plvision.eu,
        Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: prestera: flower template support
Message-ID: <20211216080849.714c3707@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1639562850-24140-1-git-send-email-volodymyr.mytnyk@plvision.eu>
References: <1639562850-24140-1-git-send-email-volodymyr.mytnyk@plvision.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 15 Dec 2021 12:07:30 +0200 Volodymyr Mytnyk wrote:
> From: Volodymyr Mytnyk <vmytnyk@marvell.com>
> 
> Add user template explicit support. At this moment, max
> TCAM rule size is utilized for all rules, doesn't matter
> which and how much flower matches are provided by user. It
> means that some of TCAM space is wasted, which impacts
> the number of filters that can be offloaded.
> 
> Introducing the template, allows to have more HW offloaded
> filters by specifying the template explicitly.
> 
> Example:
>   tc qd add dev PORT clsact
>   tc chain add dev PORT ingress protocol ip \
>     flower dst_ip 0.0.0.0/16
>   tc filter add dev PORT ingress protocol ip \
>     flower skip_sw dst_ip 1.2.3.4/16 action drop
> 
> NOTE: chain 0 is the default chain id for "tc chain" & "tc filter"
>       command, so it is omitted in the example above.
> 
> This patch adds only template support for default chain 0 suppoerted
> by prestera driver at this moment. Chains are not supported yet,
> and will be added later.
> 
> Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>

This was applied to net-next.