Subject: Re: [PATCH] dt-bindings: display: bridge: document Toshiba TC358768
 cells and panel node
To:     Rob Herring <robh+dt@kernel.org>, David Heidelberg <david@ixit.cz>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        devicetree@vger.kernel.org,
        dri-devel <dri-devel@lists.freedesktop.org>,
        ~okias/devicetree@lists.sr.ht,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20211215152712.72502-1-david@ixit.cz>
 <CAL_JsqLyMr+apgqn31V7QPfqqxhJ1ro258WsDP=CO37zfyxVNw@mail.gmail.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <63184edb-b758-6a3a-2eb8-9106b0ee0002@gmail.com>
Date:   Thu, 16 Dec 2021 19:42:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAL_JsqLyMr+apgqn31V7QPfqqxhJ1ro258WsDP=CO37zfyxVNw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

16.12.2021 18:13, Rob Herring пишет:
> On Wed, Dec 15, 2021 at 9:38 AM David Heidelberg <david@ixit.cz> wrote:
>>
>> Properties #address-cells and #size-cells are valid.
>> The bridge node can also contains panel node.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>  .../bindings/display/bridge/toshiba,tc358768.yaml      | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> index eacfe7165083..3186d9dffd98 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
>> @@ -69,6 +69,16 @@ properties:
>>        - port@0
>>        - port@1
>>
>> +  '#address-cells':
>> +    const: 1
>> +
>> +  '#size-cells':
>> +    const: 0
>> +
>> +patternProperties:
>> +  "^panel@[0-3]$":
>> +    $ref: ../panel/panel-common.yaml
> 
> It's possible to attach something that doesn't use panel-common.yaml
> and if it did, it would be applied by that schema.
> 
> What you need is to just reference dsi-controller.yaml at the top level.

It works, thank you.

Then we will also need to rename the "dsi-bridge" node to just "dsi" in
the new ASUS TF700T device-tree since dsi-controller.yaml wants that name.