MIME-Version: 1.0
References: <20211216161227.31960-1-tharvey@gateworks.com>
In-Reply-To: <20211216161227.31960-1-tharvey@gateworks.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Thu, 16 Dec 2021 11:02:11 -0600
Message-ID: <CAHCN7x+sSixbY0oSsQ0bcEsZ6CVbc+Big1Tx=WDzt1WX0ycOWA@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: imx8mn-venice-gw7902: disable gpu
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        arm-soc <linux-arm-kernel@lists.infradead.org>,
        Lucas Stach <l.stach@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Dec 16, 2021 at 10:12 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> Since commit 99aa29932271 ("arm64: dts: imx8mn: Enable GPU")
> imx8mn-venice-gw7902 will hang during kernel init because it uses
> a MIMX8MN5CVTI which does not have a GPU.
>
> Disable pgc_gpumix to work around this. We also disable the GPU devices
> that depend on the gpumix power domain and pgc_gpu to avoid them staying
> in a probe deferred state forever.
>
> Cc: Adam Ford <aford173@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>

Fixes: 99aa29932271 ("arm64: dts: imx8mn: Enable GPU")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Adam Ford <aford173@gmail.com>
> ---
>  .../boot/dts/freescale/imx8mn-venice-gw7902.dts      | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> index 236f425e1570..2d58005d20e4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> @@ -220,6 +220,10 @@
>         };
>  };
>
> +&disp_blk_ctrl {
> +       status = "disabled";
> +};
> +

Disabling the blk-ctrl also makes it so you cannot use a display
and/or CSI camera.   I don't know the application, so it's likely OK.

>  /* off-board header */
>  &ecspi2 {
>         pinctrl-names = "default";
> @@ -251,6 +255,10 @@
>         };
>  };
>
> +&gpu {
> +       status = "disabled";
> +};
> +
>  &i2c1 {
>         clock-frequency = <100000>;
>         pinctrl-names = "default";
> @@ -546,6 +554,10 @@
>         status = "okay";
>  };
>
> +&pgc_gpumix {
> +       status = "disabled";
> +};
> +
>  /* off-board header */
>  &sai3 {
>         pinctrl-names = "default";
> --
> 2.17.1
>