Date:   Thu, 16 Dec 2021 13:01:13 -0600
From:   Venu Busireddy <venu.busireddy@oracle.com>
To:     Brijesh Singh <brijesh.singh@amd.com>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Borislav Petkov <bp@alien8.de>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v8 06/40] x86/sev: Check SEV-SNP features support
Message-ID: <YbuM+WgDr+wL+jsu@dt>
References: <20211210154332.11526-1-brijesh.singh@amd.com>
 <20211210154332.11526-7-brijesh.singh@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211210154332.11526-7-brijesh.singh@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eAGEdmBrNuMdeggd0NZWBM3lrllqd0TBmywtiHbtmWqpe578XB6YvfUiOOXB?=
 =?us-ascii?Q?JnXaatGQ4k8xSd6uiw+pZpCo2GXbwEvXFOkbOIR1VYaqTnepIcZLmBPPFzj2?=
 =?us-ascii?Q?TJ5aZqjwMTqQ+VbRjgYdUOmQvnQLMSRynyY71NUTuasQrfZChNH5WT19sPaX?=
 =?us-ascii?Q?TbgOeK5Y11OySmFgj9widXzynw4gNzxZou6pkaFrBnZWiBxrr4znxHbOtmmP?=
 =?us-ascii?Q?pqrGtm6UVW7OwYBIxPGH2Tu5gg16gfa2/Dnqb2/oR6g/kxBQX8Q9azCWjJKb?=
 =?us-ascii?Q?x67PVd8Su+CIHb9FSWmyu5P6N6TILOVBSG+OzcjZXLmkKSFcg83RW8snQU1d?=
 =?us-ascii?Q?swEBkcWZeb7o/a5G3DKxD96xyjNyCQ/m/gubCVMX9uxTdVvVJLbNpxp8mGud?=
 =?us-ascii?Q?HpD+4PxWFtDql+lDXHFCy5kHohwJnrpcNKTjKoy7fRbsbAzUCD23S1M2o0j1?=
 =?us-ascii?Q?ZSGH5iWnWL6zi4JCd7BkKxy5FbRZ2BDdRDV2FMYY0+gX3dCO81JbVZWKZuTM?=
 =?us-ascii?Q?R9V1jv/KaI9zD5hklngVC/YqeqosJRfejg6ZlK5H7RXuU6SSDB2gjzVCpdaC?=
 =?us-ascii?Q?cbMaHaFYIkqUhvreaSU0iropC4c6l/9eihsmxkMtqoBHgyWqIOBg1wfAlZ9C?=
 =?us-ascii?Q?ypIrSvSgLxWFN9i7zTwgX/IiXMLHw+SxelOTEkxWtgwR5k+6DuxdW5tVD4qH?=
 =?us-ascii?Q?HgysUB8XYQpTJ4Shv9Cmkl4EXlT3wkvt6V3MhKv+I4bPfqXxG3Y9QqXyfHTz?=
 =?us-ascii?Q?FHg05iAvNRG4Kq0QYjbLbpOirSbNN1kJ1SIP5lGRckH9LEkVtagV/YYoubHe?=
 =?us-ascii?Q?RqBQ6NH+5JItwev3deZ+Z+MLco9CqqxYFy6rL+NLaQrCWphQwlXaKhQMrb9h?=
 =?us-ascii?Q?tPI9c8wVjo9t3r6NouRTCW5lmIqWcljPromi/5JU+Y3DaAJgY3OzTnW4Zm1H?=
 =?us-ascii?Q?/5PXMWJRfBfzFZRVkj3syBQmLp+miNHhsZxLPKrl+KJ4zKJ9ZddbQ+fOcmmj?=
 =?us-ascii?Q?m7O8zyVUNJ12+kC0Br8C7v2GtV7aR/RGptciZ9JAUAKpHN41eo0UYu6rYwcA?=
 =?us-ascii?Q?23uLAc7mtozkaQuiP8WpbRSaThLjhyw3ns0GhwVilupBGPRli4VNtsaActQw?=
 =?us-ascii?Q?A8gp4TJ2N+NBigD3TEoxeH0prKHKVxVAM4xAMZos69o8Aj3mqeSk2IRKLzf6?=
 =?us-ascii?Q?9NTv79JIqvRoLcoVJPJEg5DEjpNH47Og5HAzD/P80Lk8mZIf4GoNhehPdNJ6?=
 =?us-ascii?Q?BLGuEZPwB8ONkLeTvx1mxLOf9JewnHcBsXGp6q52xTXXygOjVMFv1OWtMi2w?=
 =?us-ascii?Q?CHfmyLzup0S2cG80cRaJeYzvJruMkNcRFNA3IRnFR33U3exCK238XE8xvqdt?=
 =?us-ascii?Q?NALTU12fe82LGISW+C80DaZjUUzYbjaYPDRIideO0EGeGx6QePBUZuaLAS43?=
 =?us-ascii?Q?42V3tUyut3YwjDZMfB81uhK+vaU0IL9dnP9GgTkbhQ9D2A2dtK45XgKF8z68?=
 =?us-ascii?Q?ARmius8bTUaL+JVrrel0PGqcUmLGgKVxD+tSFLn9ngK3c+4/7UWm2a7AP0aj?=
 =?us-ascii?Q?fYem68PbFoFR9D3LN9wmUMvFyDQuz/D3PpZk9BT10yuPl2ZmK3N7olYZ0vIh?=
 =?us-ascii?Q?ElXnyftL+BGm+kc1wRwe4oGkGOI5EN8uUDJMd6A2l2/2ZV6ZVHkkV4CZScFO?=
 =?us-ascii?Q?QimV1Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13783614-086a-4af3-4f9b-08d9c0c67387
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2576.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2021 19:01:22.6079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KqgROCoRgFZ8ifw4SX+Y7NHvtAMzXYF/uarD0E1UrYyuN0JwBahLuhlI593sWHyXQ8VD+uxt+VbuRlk0SRkEG2uWxo0fs4QLdTSUF+RpRTc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2621
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10200 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2112160105
X-Proofpoint-ORIG-GUID: jbccMwoIjphroNV3RQFMZLVeopGdnTU9
X-Proofpoint-GUID: jbccMwoIjphroNV3RQFMZLVeopGdnTU9
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2021-12-10 09:42:58 -0600, Brijesh Singh wrote:
> Version 2 of the GHCB specification added the advertisement of features
> that are supported by the hypervisor. If hypervisor supports the SEV-SNP
> then it must set the SEV-SNP features bit to indicate that the base
> SEV-SNP is supported.
> 
> Check the SEV-SNP feature while establishing the GHCB, if failed,
> terminate the guest.
> 
> Version 2 of GHCB specification adds several new NAEs, most of them are
> optional except the hypervisor feature. Now that hypervisor feature NAE
> is implemented, so bump the GHCB maximum support protocol version.
> 
> While at it, move the GHCB protocol negotitation check from VC exception
> handler to sev_enable() so that all feature detection happens before
> the first VC exception.
> 
> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
> ---
>  arch/x86/boot/compressed/sev.c    | 21 ++++++++++++++++-----
>  arch/x86/include/asm/sev-common.h |  6 ++++++
>  arch/x86/include/asm/sev.h        |  2 +-
>  arch/x86/include/uapi/asm/svm.h   |  2 ++
>  arch/x86/kernel/sev-shared.c      | 20 ++++++++++++++++++++
>  arch/x86/kernel/sev.c             | 16 ++++++++++++++++
>  6 files changed, 61 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 0b6cc6402ac1..a0708f359a46 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -119,11 +119,8 @@ static enum es_result vc_read_mem(struct es_em_ctxt *ctxt,
>  /* Include code for early handlers */
>  #include "../../kernel/sev-shared.c"
>  
> -static bool early_setup_sev_es(void)
> +static bool early_setup_ghcb(void)
>  {
> -	if (!sev_es_negotiate_protocol())
> -		sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SEV_ES_PROT_UNSUPPORTED);

Should the name sev_es_terminate() be changed to a more generic
name, as we are simply terminating the guest, not SEV or ES as the
name implies?

Other than that...

Reviewed-by: Venu Busireddy <venu.busireddy@oracle.com>